Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] Fix pylint and mypy #21939

Merged
merged 4 commits into from
Nov 30, 2021
Merged

[EventHubs] Fix pylint and mypy #21939

merged 4 commits into from
Nov 30, 2021

Conversation

yunhaoling
Copy link
Contributor

No description provided.

@ghost ghost added the Event Hubs label Nov 30, 2021
swathipil
swathipil approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - (I also made the pylint changes in this PR: #21884
But I can just wait for your changes to merge first!)

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub. You can review API changes here

API changes

-         ) -> _AccessToken
+         ) -> AccessToken
-         )
+         ) -> AccessToken

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob-aio. You can review API changes here

API changes

-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 
-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ...,

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob. You can review API changes here

API changes

-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 
-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ...,

@yunhaoling yunhaoling merged commit aa0f563 into Azure:main Nov 30, 2021
@yunhaoling yunhaoling deleted the yuling/eh/fix-mypy-pylint branch November 30, 2021 23:01
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 1, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
c77806a 
…into add_body_error

* 'main' of https://github.com/Azure/azure-sdk-for-python: (74 commits)
  Pin Crypto Temporarily (Azure#21950)
  [release-helper] check `default tag` and `target tag` consistency (Azure#21952)
  [EventHubs] remove unused import (Azure#21949)
  [KV] Use shared test-resources.json (Azure#21940)
  [EventHubs] Fix pylint and mypy (Azure#21939)
  fix line in general document sample code (Azure#21936)
  Pipeline auto-discover stress test (Azure#21917)
  resolve the issue the bad condition in dump proxy logs (Azure#21947)
  [KV] Correctly fetch private RSA key material (Azure#21938)
  doc (Azure#21830)
  Sync eng/common directory with azure-sdk-tools for PR 2348 (Azure#21919)
  [EventHubs] ensure ownership arg does not mutate (Azure#20008)
  Fix the type for LROPoller wait timeout (Azure#21913)
  [EventHubs]Update async samples (Azure#21857)
  [AutoRelease] t2-containerservice-2021-11-25-33508 (Azure#21891)
  update for Go (Azure#21898)
  [pipeline] SDK Release helper : 0.0.1 (Azure#21888)
  [AutoRelease] t2-subscription-2021-11-25-24271 (Azure#21892)
  Release issue status (Azure#21887)
  [AutoRelease] t2-datafactory-2021-11-20-87712 (Azure#21840)
  ...
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Jan 4, 2022
@yunhaoling @hildurhodd
[EventHubs] Fix pylint and mypy (Azure#21939)
0d92023 
* fix pylint

* fix credential mypy

* one more place

* more lint
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Feb 1, 2023
@komo23x @namanag16
@ZhidaLiu @libc16
CodeGen from PR 21761 in Azure/azure-rest-api-specs
cb54b44 
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761)

* Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Dec API Registries Swagger (Azure#21419)

* add december registries swagger + examples

* add status code 202 in examples

* fix 202 examples

* fixes

* fixes

* fix

* add 202 back in for put/patch

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove location (Azure#21430)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* remove readonly flag on schedules property for CI (Azure#21653)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* add missing workspace properties (Azure#21725)

* December preview updating mfe.json specs (Azure#21510)

* December preview updating mfe.json specs

* MFE Dec 2022 Preview API - Adding logbase

* MFE 2022-12-01-preview swagger spec model validation fix

* MFE 2022-12-01-preview swagger spec model validation fix, add missing location

* MFE 2022-12-01-preview swagger spec model validation - typo fix

* MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error

* Fix  for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822)

* fix ReadonlyPropertyChanged of MLC (Azure#21814)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* fixed custom-words conflict (Azure#21829)

* fix custom-words conflict merge (Azure#21830)

* example fix (INVALID_REQUEST_PARAMETER) (Azure#21832)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* example fix, use correct api preview version  - (INVALID_REQUEST_PARAMETER) (Azure#21833)

Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>

* Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885)

Co-authored-by: Bingchen Li <bingchenli@microsoft.com>

* Revert Connection Category back to enum. (Azure#21939)

* revert provisioning state change (Azure#21940)

* remove body (Azure#21978)

Co-authored-by: Komal Yadav <komalyadav@microsoft.com>

* Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* Ivalbert fix patch2 (Azure#22006)

* Addressed comments, added x-ms-long-running-operation to a patch call

* fix examples for patch - remove body

* fixed formatting

* fixed formatting

* Updated custom words (Azure#22262)

* Fixed prettier errors (Azure#22237)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22293)

* fixed examples for LRO_RESPONSE_HEADER check (Azure#22294)

* Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (Azure#22317)

---------

Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhaoling @azure-sdk @swathipil