Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SchemaRegistry] migrate to test proxy #23438

Merged
12 commits merged into from
Mar 11, 2022

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Mar 9, 2022

fixes #22517

@ghost ghost added the Schema Registry label Mar 9, 2022
@swathipil
Copy link
Member Author

/azp run python - schemaregistry - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@swathipil
Copy link
Member Author

/azp run python - schemaregistry - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil marked this pull request as ready for review March 9, 2022 22:20
@check-enforcer
Copy link

check-enforcer bot commented Mar 9, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for doing this migration!

@swathipil
Copy link
Member Author

/azp run python - schemaregistry - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Mar 10, 2022

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@swathipil
Copy link
Member Author

/azp run python - schemaregistry - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - schemaregistry - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost merged commit 0707184 into Azure:main Mar 11, 2022
@swathipil swathipil deleted the swathipil/sr/migrate-test-proxy branch March 11, 2022 18:17
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
fixes Azure#22517

- need to ignore pylint `import-error` due to same issue as here: pylint-dev/pylint#2862
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
fixes Azure#22517

- need to ignore pylint `import-error` due to same issue as here: pylint-dev/pylint#2862
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 9, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (62 commits)
  pass polling interval 0 for playback (Azure#23514)
  [webpubsub] switch to customizations code (Azure#23504)
  [AutoRelease] t2-netapp-2022-02-11-58164(Do not merge) (Azure#23214)
  [Key Vault] Address architect feedback (Azure#23475)
  Sync eng/common directory with azure-sdk-tools for PR 2910 (Azure#23499)
  check content (Azure#23496)
  fix cspell issues (Azure#22948)
  API Key Not Being Passed On Paged Requests (Azure#23477)
  [AutoRelease] t2-labservices-2022-03-14-64385 (Azure#23492)
  [Release issue status] fix date bug and serve Python only (Azure#23491)
  [SchemaRegistry] migrate to test proxy (Azure#23438)
  [compute] update test (Azure#23456)
  update servicebus test (Azure#23401)
  Update search test (Azure#23341)
  Update resources test (Azure#23340)
  Update relay test (Azure#23339)
  Update notificationhubs test (Azure#23338)
  Update network-dns test (Azure#23337)
  update network test (Azure#23421)
  update logic (Azure#23463)
  ...
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Apr 14, 2023
[NetAppFiles]Anf 26457 s360 linting remove backup policy details (Azure#23438)

* Remove backupPolicyDetails, not used

* remove x-ms-azure-resource from proxy resources snapshots and backups
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SchemaRegistry] Migrate SR tests to use test proxy
2 participants