[Key Vault] Address architect feedback #23475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
|
API changes have been detected in |
YalinLi0312
approved these changes
Mar 11, 2022
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 15, 2022
…into qna_customizations * 'main' of https://github.com/Azure/azure-sdk-for-python: pass polling interval 0 for playback (Azure#23514) [webpubsub] switch to customizations code (Azure#23504) [AutoRelease] t2-netapp-2022-02-11-58164(Do not merge) (Azure#23214) [Key Vault] Address architect feedback (Azure#23475) Sync eng/common directory with azure-sdk-tools for PR 2910 (Azure#23499) check content (Azure#23496)
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 9, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (62 commits) pass polling interval 0 for playback (Azure#23514) [webpubsub] switch to customizations code (Azure#23504) [AutoRelease] t2-netapp-2022-02-11-58164(Do not merge) (Azure#23214) [Key Vault] Address architect feedback (Azure#23475) Sync eng/common directory with azure-sdk-tools for PR 2910 (Azure#23499) check content (Azure#23496) fix cspell issues (Azure#22948) API Key Not Being Passed On Paged Requests (Azure#23477) [AutoRelease] t2-labservices-2022-03-14-64385 (Azure#23492) [Release issue status] fix date bug and serve Python only (Azure#23491) [SchemaRegistry] migrate to test proxy (Azure#23438) [compute] update test (Azure#23456) update servicebus test (Azure#23401) Update search test (Azure#23341) Update resources test (Azure#23340) Update relay test (Azure#23339) Update notificationhubs test (Azure#23338) Update network-dns test (Azure#23337) update network test (Azure#23421) update logic (Azure#23463) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses another round of feedback for
azure-keyvault-keys, which all has to do with type hints.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines