[Feature][Calling] CSS call history #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigoryk
requested changes
Jan 31, 2023
There was a problem hiding this comment.
Did a first pass, mostly just on the db stuff. It mostly looks fine, but see comments around specifics.
In summary:
- better lifecycle of the db connection (don't throw away the opened connection)
- simplify schema (remove
id) - simplify cleanup logic, make it part of an insert logic as a single DELETE in a transaction; won't need a
removemethod then - switch to just using Long for start timestamp. it's more correct, and you won't need to do all that time parsing stuff and won't need a threetenbp library include (or desugaring java8+ features)
- I'm fairly sure you're doing all the db operations on the main dispatcher (due to using lifecycleScope), which is not what you want. Use a dedicated single-threaded executor instead (since sqlite is inherently single-threaded and won't like it if we write simultaneously on different threads).
...src/main/java/com/azure/android/communication/ui/calling/data/model/CallHistoryRecordData.kt
Outdated
Show resolved
Hide resolved
...ication-ui/calling/src/main/java/com/azure/android/communication/ui/calling/data/DbHelper.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...ication-ui/calling/src/main/java/com/azure/android/communication/ui/calling/data/DbHelper.kt
Outdated
Show resolved
Hide resolved
...ication-ui/calling/src/main/java/com/azure/android/communication/ui/calling/data/DbHelper.kt
Outdated
Show resolved
Hide resolved
15 tasks
ahammer
reviewed
Feb 8, 2023
.../calling/src/main/java/com/azure/android/communication/ui/calling/CallCompositeExtentions.kt
Outdated
Show resolved
Hide resolved
grigoryk
reviewed
Feb 9, 2023
...c/main/java/com/azure/android/communication/ui/calling/presentation/CallCompositeActivity.kt
Show resolved
Hide resolved
...ication-ui/calling/src/main/java/com/azure/android/communication/ui/calling/data/DbHelper.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
...i/calling/src/test/java/com/azure/android/communication/ui/service/CallHistoryServiceTest.kt
Show resolved
Hide resolved
...ain/java/com/azure/android/communication/ui/calling/presentation/manager/DebugInfoManager.kt
Show resolved
Hide resolved
...calling/src/main/java/com/azure/android/communication/ui/calling/redux/state/CallingState.kt
Outdated
Show resolved
Hide resolved
grigoryk
previously approved these changes
Feb 28, 2023
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Show resolved
Hide resolved
...lling/src/main/java/com/azure/android/communication/ui/calling/data/CallHistoryRepository.kt
Outdated
Show resolved
Hide resolved
grigoryk
approved these changes
Feb 28, 2023
ahammer
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
Pull Request Checklist
How to Test
What to Check
Verify that the following are valid
Other Information