Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Calling][CSS] Call history #610

Merged
merged 29 commits into from
Mar 7, 2023
Merged

[Feature][Calling][CSS] Call history #610

merged 29 commits into from
Mar 7, 2023

Conversation

pavelprystinka
Copy link
Member

Purpose

  • Call history

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Pull request checklist

This PR has considered:

  • Color Theming
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • View Data Injection
  • Demo App UI/UX update

How to Test

  • Open...
  • Click on...

What to Check

Before After
Screenshot or description before this change Screenshot or description with this change

Other Information

@pavelprystinka pavelprystinka requested review from a team as code owners January 27, 2023 17:21
@acs-ui-bot acs-ui-bot added the feature For new features intended for a future release label Jan 27, 2023
@grigoryk
Copy link
Member

@pavelprystinka can you please check how much of my feeback on Azure/communication-ui-library-android#710 applies here?

emlynmac
emlynmac requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to preserve the public interface.

...CommunicationUI/sdk/AzureCommunicationUICalling/Sources/CallCompositeOptions/DebugInfo.swift Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/CallHistoryRepository.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/CallHistoryRepository.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/CallHistoryRepository.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/CallHistoryRepository.swift Outdated Show resolved Hide resolved
...unicationUI/sdk/AzureCommunicationUICalling/Sources/Service/Calling/CallHistoryService.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/AzureCommunicationUIDemoApp/Sources/Views/CallingDemoView.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/AzureCommunicationUIDemoApp/Sources/Views/CallingDemoViewController.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/CallHistoryRepository.swift Outdated Show resolved Hide resolved
...unicationUI/sdk/AzureCommunicationUICalling/Sources/Service/Calling/CallHistoryService.swift Outdated Show resolved Hide resolved
@emlynmac
Copy link
Member

emlynmac commented Feb 8, 2023

It would be preferable to move the persistence of the call IDs into the lower-level Calling SDK, so that all consumers of that library will benefit.
Have we considered this approach?

emlynmac
emlynmac reviewed Mar 6, 2023
View reviewed changes
AzureCommunicationUI/AzureCommunicationUIDemoApp/Sources/Views/CallingDemoView.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/AzureCommunicationUIDemoApp/Sources/Views/CallingDemoViewController.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/AzureCommunicationUIDemoApp/Sources/Views/CallingDemoViewController.swift Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/CallHistoryRepository.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/UserDefaultsStorage.swift Outdated Show resolved Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUICalling/Sources/Data/UserDefaultsStorage.swift Outdated Show resolved Hide resolved
eng/pipelines/nightly.yml Show resolved Hide resolved
@pavelprystinka pavelprystinka merged commit 2ed8e5c into release/AzureCommunicationUICalling_1.2.0 Mar 7, 2023
@pavelprystinka pavelprystinka deleted the feature/css_call_history_v1 branch March 7, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@palatter palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-ios-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-ios-reviewer-1

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai was automatically assigned from Azure/acs-ui-ios-reviewer-2

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft was automatically assigned from Azure/acs-ui-ios-reviewer-3

Assignees
No one assigned
Labels
feature For new features intended for a future release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelprystinka @grigoryk @emlynmac @vhuseinova-msft @acs-ui-bot