Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] CallOnHold layerView error banner/controlBar update #217

Merged
merged 8 commits into from
May 30, 2022
Merged

[Feature] CallOnHold layerView error banner/controlBar update #217

merged 8 commits into from
May 30, 2022

Conversation

AmyL219
Copy link
Contributor

@AmyL219 AmyL219 commented May 27, 2022 •
edited
Loading

Purpose

  • Display error Banner inside onHoldOverlayView when error show up
  • Disable control bar when call is on hold
    MicrosoftTeams-image (35)

MicrosoftTeams-image (34)

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@AmyL219 AmyL219 requested review from a team as code owners May 27, 2022 15:29
@AmyL219 AmyL219 requested review from waynemo, palatter, JoshuaLai, jimchou-dev, kevinyulu and vhuseinova-msft and removed request for a team May 27, 2022 15:29
@AmyL219 AmyL219 changed the title [Feature] CallOnHold layerView UI/UX update [Feature] CallOnHold layerView error banner/controlBar update May 27, 2022
@AmyL219 AmyL219 requested a review from iaulakh May 27, 2022 22:46
kevinyulu
kevinyulu reviewed May 27, 2022
View reviewed changes
Copy link
Contributor

@kevinyulu kevinyulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a user is in the teams call lobby, looks like the on hold overlay is not showing. should it be shown?

...icationUICalling/Presentation/SwiftUI/Calling/CallingViewComponent/ControlBarViewModel.swift Outdated Show resolved Hide resolved
...icationUICalling/Presentation/SwiftUI/Calling/CallingViewComponent/ControlBarViewModel.swift Show resolved Hide resolved
@kevinyulu kevinyulu self-requested a review May 30, 2022 18:43
kevinyulu
kevinyulu approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@kevinyulu kevinyulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested lgtm

@AmyL219 AmyL219 merged commit c383016 into task/call-on-hold-ui-changes May 30, 2022
@AmyL219 AmyL219 deleted the amy/callOnHoldUIUpdate branch May 30, 2022 22:39
@AmyL219 AmyL219 mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinyulu kevinyulu kevinyulu approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@palatter palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-ios-reviewer-1

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai was automatically assigned from Azure/acs-ui-ios-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev was automatically assigned from Azure/acs-ui-ios-reviewer-2

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-ios-reviewer-3

@iaulakh iaulakh Awaiting requested review from iaulakh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmyL219 @kevinyulu