Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add CallOnHold feature when there is audio session interruption #223

Merged
merged 19 commits into from
Jun 3, 2022
Merged

[Feature] Add CallOnHold feature when there is audio session interruption #223

merged 19 commits into from
Jun 3, 2022

Conversation

AmyL219
Copy link
Contributor

@AmyL219 AmyL219 commented May 31, 2022 •
edited by palatter
Loading

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code

@AmyL219 AmyL219 requested review from a team as code owners May 31, 2022 15:52
@acs-ui-bot acs-ui-bot added the feature For new features intended for a future release label May 31, 2022
palatter
palatter previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@palatter palatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

jimchou-dev
jimchou-dev previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@jimchou-dev jimchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@AmyL219 AmyL219 dismissed stale reviews from jimchou-dev and palatter via d839cff June 2, 2022 16:21
jimchou-dev
jimchou-dev previously approved these changes Jun 2, 2022
View reviewed changes
palatter
palatter previously approved these changes Jun 2, 2022
View reviewed changes
jimchou-dev
jimchou-dev previously approved these changes Jun 2, 2022
View reviewed changes
@palatter
Merge branch 'develop/beta' into feature/callOnHold
c9cc019 
# Conflicts:
#	AzureCommunicationUI/sdk/AzureCommunicationUICalling/AzureCommunicationUICalling.xcodeproj/project.pbxproj
@palatter palatter dismissed stale reviews from jimchou-dev and themself via c9cc019 June 2, 2022 21:38
@AmyL219 AmyL219 merged commit 090793e into develop/beta Jun 3, 2022
@AmyL219 AmyL219 deleted the feature/callOnHold branch June 3, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palatter palatter palatter approved these changes

@jimchou-dev jimchou-dev jimchou-dev approved these changes

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-ios-reviewer-1

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai was automatically assigned from Azure/acs-ui-ios-reviewer-2

@kevinyulu kevinyulu Awaiting requested review from kevinyulu kevinyulu was automatically assigned from Azure/acs-ui-ios-reviewer-3

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-ios-reviewer-3

Assignees
No one assigned
Labels
feature For new features intended for a future release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmyL219 @palatter @jimchou-dev @acs-ui-bot