Fixes #684.

Azure · Apr 29, 2024 · 57b0329 · 57b0329
1 parent 74a3d6c
commit 57b0329
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 1 deletion.
diff --git a/packages/typespec-azure-core/src/rules/rpc-operation-request-body.ts b/packages/typespec-azure-core/src/rules/rpc-operation-request-body.ts
@@ -26,8 +26,9 @@ export const rpcOperationRequestBodyRule = createRule({
             operation.namespace?.namespace?.name === "Azure"
           ) {
             const httpOperation = getHttpOperation(context.program, originalOperation)[0];
+            const bodyParam = httpOperation.parameters.body;
             const verb = httpOperation.verb.toLowerCase();
-            if (verb === "get" || verb === "delete") {
+            if ((verb === "get" || verb === "delete") && bodyParam !== undefined) {
               context.reportDiagnostic({
                 target: originalOperation,
                 messageId: "noBodyAllowed",

diff --git a/packages/typespec-azure-core/test/rules/rpc-operation-request-body.test.ts b/packages/typespec-azure-core/test/rules/rpc-operation-request-body.test.ts
@@ -20,6 +20,38 @@ describe("typespec-azure-core: rpc-operation-request-body", () => {
     );
   });
 
+  it("allow RPCOperation with `@get` and empty body", async () => {
+    await tester
+      .expect(
+        `
+        model Widget {
+          name: string;
+        }
+
+        @get
+        @route ("/")
+        op getWidget is RpcOperation<{}, Widget>;
+      `
+      )
+      .toBeValid();
+  });
+
+  it("allow RPCOperation with `@delete` and empty body", async () => {
+    await tester
+      .expect(
+        `
+        model Widget {
+          name: string;
+        }
+
+        @delete
+        @route ("/")
+        op deleteWidget is RpcOperation<{}, Widget>;
+      `
+      )
+      .toBeValid();
+  });
+
   it("emits warning when RPCOperation is marked with `@get` and has a request body", async () => {
     await tester
       .expect(