Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: rpc-operation-request-body rule is reporting false positive when using with @get and empty params #684

Closed
4 tasks done
timotheeguerin opened this issue Apr 17, 2024 · 1 comment · Fixed by #760
Closed
4 tasks done

[Bug]: rpc-operation-request-body rule is reporting false positive when using with @get and empty params #684

timotheeguerin opened this issue Apr 17, 2024 · 1 comment · Fixed by #760
Assignees
@tjprescott
Labels
bug Something isn't working
Milestone
[2024] June

Comments

@timotheeguerin
Copy link
Member

Describe the bug

Rule is reporting an error when you don't actually set any params as you pass {}

Reproduction

playground

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@timotheeguerin timotheeguerin added the bug Something isn't working label Apr 17, 2024
@markcowl markcowl added this to the [2024] June milestone Apr 18, 2024
@tjprescott tjprescott self-assigned this Apr 29, 2024
@tjprescott
Copy link
Member

Same with @delete.

tjprescott added a commit that referenced this issue Apr 29, 2024
@tjprescott
Fixes #684.
57b0329
@tjprescott tjprescott mentioned this issue Apr 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@tjprescott
Core: Fix rpc-operation-request-body rule (#760)
40c05ff 
Turns out this rule was never actually looking for a request body at
all. It only cared if you were using the RpcOperation tempalte with
`@get` or `@delete`!

Fixes #684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjprescott tjprescott

Labels
bug Something isn't working
Projects
None yet
Milestone
[2024] June
Development

Successfully merging a pull request may close this issue.

Core: Fix rpc-operation-request-body rule Azure/typespec-azure
3 participants
@timotheeguerin @markcowl @tjprescott