Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Newton error propagation based convergence check." #1419

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Sep 2, 2024

Second attempt at implementing Newton error propagation
based convergence check.

Adds EIGEN_DEVICE_FUNC to is_converged for GPU builds.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 2, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 3, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 4, 2024
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #230002 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 11, 2024
@1uc
Copy link
Collaborator Author

1uc commented Sep 12, 2024

CI went green for NRN with this PR: neuronsimulator/nrn#3068

@1uc 1uc marked this pull request as ready for review September 12, 2024 06:45
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Sep 12, 2024
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/solver/newton/newton.hpp Show resolved Hide resolved
@1uc 1uc merged commit 5abff4f into master Sep 13, 2024
21 checks passed
@1uc 1uc deleted the 1uc/reattempt-newton-error branch September 13, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants