Fix: don't use joined relationship for 'favorite' parameter (#948)

CERT-Polska · Jul 3, 2024 · 4996804 · 4996804
1 parent 8be8607
commit 4996804
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/mwdb/model/object.py b/mwdb/model/object.py
@@ -99,9 +99,7 @@ class Object(db.Model):
         cascade="save-update, merge, delete",
     )
 
-    followers = db.relationship(
-        "User", secondary=favorites, back_populates="favorites", lazy="joined"
-    )
+    followers = db.relationship("User", secondary=favorites, back_populates="favorites")
 
     comment_authors = db.relationship(
         "User",

diff --git a/mwdb/model/user.py b/mwdb/model/user.py
@@ -61,7 +61,7 @@ class User(db.Model):
         back_populates="related_user",
     )
     favorites = db.relationship(
-        "Object", secondary=favorites, back_populates="followers", lazy="joined"
+        "Object", secondary=favorites, back_populates="followers"
     )
 
     commented_objects = db.relationship(