Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't use joined relationship for 'favorite' parameter #948

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jul 3, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

Followers are joined for every Object instance and Favorites are joined for every User instance. It's completely unnecessary and has negative impact on query performance.

Joined relationships in objects should be used only for fields included in listing schemas like ObjectListItemResponseSchema to avoid N+1 problem.

What is the new behaviour?

Favorites/Followers are loaded lazily.

@psrok1 psrok1 merged commit 4996804 into master Jul 3, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/followers-too-eager branch July 3, 2024 16:00
@psrok1 psrok1 mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant