Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mobile #305

Merged
merged 41 commits into from
Aug 12, 2024
Merged

Fix/mobile #305

merged 41 commits into from
Aug 12, 2024

Conversation

u21631532
Copy link
Contributor

Pull Request: Updated Booking Flow and Improved Logout Functionality

Description

This pull request includes significant updates to our Expo and React Native application, focusing on enhancing the booking flow, adding new logic, and improving the logout functionality. These changes aim to improve user experience and backend integration.

Key changes:

  1. Updated booking flow
  2. Added new logic for logout, bookings and other tasks in the issues
  3. Improved logout functionality, now working correctly with the backend

Motivation: These changes were needed based on performance and other quality requirementes that we had to meet. Also feedback from the usablity test helped.

Related issue: #304 #303 #302 #301 #300

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The following tests were conducted to verify these changes:

  • Unit tests for new booking flow logic
  • Integration tests for booking flow with other app components
  • End-to-end tests of the entire booking process
  • Logout functionality tests across different scenarios (e.g., different user types, network conditions)
  • Performance profiling of updated booking flow
  • Security testing of logout process

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

  • The updated booking flow may require A/B testing to validate improvements
  • Logout changes may require updates to user session management on the backend
  • Consider monitoring app analytics after deployment to gauge user interaction with the new booking process

u21631532 and others added 30 commits August 8, 2024 13:07
@u21631532 u21631532 added type: feature A new feature type: fix Introduces a fix for a previous issue type: testing This affects one or more tests For: frontend This is mainly related to frontend UI code priority: high This needs/needed to be addressed as soon as possible effort: 8 This may require/required a week of work at minimum platform: mobile This is related to mobile platforms For: deployment This will affect our deployed system labels Aug 12, 2024
@u21631532 u21631532 added this to the Week 6 Sprint 3 FINAL!!! milestone Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 6.12245% with 46 lines in your changes missing coverage. Please review.

Project coverage is 33.07%. Comparing base (1565b63) to head (2360606).
Report is 84 commits behind head on develop.

Files Patch % Lines
frontend/occupi-mobile4/utils/occupancy.ts 0.00% 24 Missing ⚠️
frontend/occupi-mobile4/services/apiservices.ts 0.00% 10 Missing ⚠️
frontend/occupi-mobile4/services/aimodel.ts 0.00% 7 Missing ⚠️
frontend/occupi-mobile4/utils/bookings.ts 0.00% 4 Missing ⚠️
frontend/occupi-mobile4/services/securestore.ts 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1565b63) and HEAD (2360606). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1565b63) HEAD (2360606)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #305       +/-   ##
============================================
- Coverage    78.98%   33.07%   -45.92%     
============================================
  Files           30       11       -19     
  Lines         2327      517     -1810     
  Branches         0       76       +76     
============================================
- Hits          1838      171     -1667     
+ Misses         443      319      -124     
+ Partials        46       27       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@u21631532 u21631532 merged commit ed66079 into develop Aug 12, 2024
3 of 5 checks passed
@KamogeloMoeketse KamogeloMoeketse deleted the fix/mobile branch August 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 8 This may require/required a week of work at minimum For: deployment This will affect our deployed system For: frontend This is mainly related to frontend UI code platform: mobile This is related to mobile platforms priority: high This needs/needed to be addressed as soon as possible type: feature A new feature type: fix Introduces a fix for a previous issue type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants