b3dm to cesium 3dtiles batch table #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 25, 2020 13:41
Future Improvments: - Support for binary data (data must be stored in batchTables / properties right now as human readable data.) - GLB Support - Unittests!
This prevents adding `code` and `cartographic` to the outputted gltf in two locations
lilleyse
reviewed
Feb 27, 2020
Remove deferGlbConversion function
Co-Authored-By: Sean Lilley <lilleyse@gmail.com>
added 10 commits
March 4, 2020 09:37
lilleyse
reviewed
Mar 4, 2020
Co-Authored-By: Sean Lilley <lilleyse@gmail.com>
Co-Authored-By: Sean Lilley <lilleyse@gmail.com>
…mGS/3d-tiles-validator into b3dm_to_CESIUM_3dtiles_batch_table
Co-Authored-By: Sean Lilley <lilleyse@gmail.com>
…mGS/3d-tiles-validator into b3dm_to_CESIUM_3dtiles_batch_table
|
@lilleyse Feedback addressed, there's still the issue of all gltfs passing validation but some glbs failing. |
|
@Samulus I made a few last minute changes:
|
|
All looks good to me now! |
Samulus
changed the title
Samulus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip, not ready to merge yetneeds reviews
Has:
code/cartographicproperties concatenated togetherFeatureTables(Deprecated, RTC_CENTER is becoming a GLTF node, will make a demo using this in a follow up PR)Avoid writing redundantsee comment in PR about thisidpropertyNeeds: