Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone options before modifying options #528

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Clone options before modifying options #528

merged 1 commit into from
Mar 4, 2020

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Mar 4, 2020

This PR clones the options object before setting internal properties to it.

This resulted in a race condition in CesiumGS/3d-tiles-validator#186 where calls to gltfToGlb and processGltf were sharing the same options object that was getting modified internally by gltf-pipeline.

@lilleyse lilleyse merged commit 1e27e2b into master Mar 4, 2020
@lilleyse lilleyse deleted the clone-options branch March 4, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant