-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace glTF model implementation #10644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw `RuntimeError` for glTF 1.0 and unsupported extensions in `ModelExperimental`
Rename `ModelExperimental` files that don't conflict with `Model`
Ensure spec parity between `Model` and `ModelExperimental`
Rename peripheral model classes
…only Remove ability to toggle `classificationType` at runtime
Remove unused glTF models from Specs/Data
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
Does this implicitly close #10416 as well? |
We should close the roadmap issue once this is merged: #10346
|
@j9liu I updated the description so this PR closes those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10346
Fixes #10416
Fixes #10379
Fixes #9303
Fixes #7062
Fixes #6299
Fixes #2387
This PR replaces CesiumJS's glTF model implementation. the old
Model
was removed, andModelExperimental
was renamed toModel
as a drop-in replacement. The new architecture is a lot more decoupled, and it made it easier to implement features such as 3D Tiles Next metadata andCustomShader
This PR merges the staging branch
replace-model
intomain
. It includes changes from the following PRs:RuntimeError
for glTF 1.0 and unsupported extensions inModelExperimental
#10595Model
andModelExperimental
#10600ModelExperimental
handle classification #10623classificationType
at runtime #10643Model
and renameModelExperimental -> Model
#10637To Do:
@experimental
anywhereAdd changes from Convert glTF 1.0 techniques to PBR materials by default gltf-pipeline#619 so we can have (limited) support forWill be done separatelyglTF 1.0
andKHR_techniques_webgl