-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXT_feature_metadata feedback #9
Conversation
@donmccurdy the spec went through a few iterations, first in #1, and then two revisions in the current branch. One thing we plan to do soon is remove the landing page and move the change log to a separate section in the document like OpenGL extensions. I might do this reorg now so it's easier to review. |
@donmccurdy all set now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think these comments are the last of the larger technical feedback that I'm seeing. If there are any of these we'd like to act on, I'm happy to open a PR. Or if not, to shift gears into language and clarity comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still thinking a bit about parallelism in ID textures and ID attributes, but adding a couple followup thoughts on feature textures. Resolved in #14.
…feature indicators.
…s/propertyTextures
Rename EXT_feature_metadata → EXT_mesh_features
… on feature tables and textures.
EXT_feature_metadata: Restrictions on string IDs, add property table and texture names
Restore EXT_feature_metadata alongside EXT_mesh_features
Consolidate staging branches
Update EXT_mesh_features changelog
I think my remaining feedback on |
See #4 for @pjcozzi's feedback and see #3 for the original PR.
Direct link to extension: https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_feature_metadata