Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXT_feature_metadata feedback #9

Closed
wants to merge 78 commits into from
Closed

EXT_feature_metadata feedback #9

wants to merge 78 commits into from

Commits on Sep 26, 2021

  1. Feature metadata draft

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e4ea9a4 View commit details
    Browse the repository at this point in the history

  2. New draft for version 1.0.0

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    1b225c9 View commit details
    Browse the repository at this point in the history

  3. Add examples section

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    351136f View commit details
    Browse the repository at this point in the history

  4. Updates from review

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    1f16409 View commit details
    Browse the repository at this point in the history

  5. Fix min/max schema

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    b873edb View commit details
    Browse the repository at this point in the history

  6. Peer review edits

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c6a3624 View commit details
    Browse the repository at this point in the history

  7. Resolve TODOs

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    3935e9f View commit details
    Browse the repository at this point in the history

  8. Wording

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    649d67b View commit details
    Browse the repository at this point in the history

  9. Insert Wetzel output

    @ptrgags @lilleyse
    ptrgags authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    af2b0d2 View commit details
    Browse the repository at this point in the history

  10. Wetzel output revisions

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c453bf6 View commit details
    Browse the repository at this point in the history

  11. Add last figure

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c7c4a1d View commit details
    Browse the repository at this point in the history

  12. Addressed review feedback

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    21b410f View commit details
    Browse the repository at this point in the history

  13. Fix schema TOC indentation

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e4c93b3 View commit details
    Browse the repository at this point in the history

  14. Don't make class required in case the model does not have metadata

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    1eb04ad View commit details
    Browse the repository at this point in the history

  15. Schema wording tweaks

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    4dbd915 View commit details
    Browse the repository at this point in the history

  16. Change bufferView type back to integer

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    3131bd4 View commit details
    Browse the repository at this point in the history

  17. Update extensions/2.0/Vendor/EXT_feature_metadata/1.0.0/schema/featur… 

    …eTable.property.schema.json

Co-authored-by: Peter Gagliardi <ptrgags@gmail.com>
    @lilleyse @ptrgags
    lilleyse and ptrgags committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    391235c View commit details
    Browse the repository at this point in the history

  18. Update links to Cesium 3D Metadata spec

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    34d52ea View commit details
    Browse the repository at this point in the history

  19. Update date

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    fbb345a View commit details
    Browse the repository at this point in the history

  20. Minor updates

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9c11809 View commit details
    Browse the repository at this point in the history

  21. Update links to EXT_mesh_gpu_instancing

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    a192bd1 View commit details
    Browse the repository at this point in the history

  22. Reorder classes/enums

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    7d454aa View commit details
    Browse the repository at this point in the history

  23. Wording

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e079b86 View commit details
    Browse the repository at this point in the history

  24. Tweaks

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    afe7355 View commit details
    Browse the repository at this point in the history

  25. Update README.md

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c46d566 View commit details
    Browse the repository at this point in the history

  26. Clarify enum binary properties

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    79937fd View commit details
    Browse the repository at this point in the history

  27. Fix year

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9537e61 View commit details
    Browse the repository at this point in the history

  28. Change number to integer in JSON schema

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    25d100f View commit details
    Browse the repository at this point in the history

  29. Remove landing page

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    173fba2 View commit details
    Browse the repository at this point in the history

  30. Add revision history section

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    2912d17 View commit details
    Browse the repository at this point in the history

  31. Remove version number and links to versions

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    926f53a View commit details
    Browse the repository at this point in the history

  32. Don't use non-standard not.required mechanism. 

    Also don't mark any properties of gltf.EXT_feature_metadata required,
because I don't think they are.
    @kring @lilleyse
    kring authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c27ce9f View commit details
    Browse the repository at this point in the history

  33. Specify item type of statistic arrays.

    @kring @lilleyse
    kring authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    f7b6146 View commit details
    Browse the repository at this point in the history

  34. Add item types to class properties schema.

    @kring @lilleyse
    kring authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e6d1d7a View commit details
    Browse the repository at this point in the history

  35. Avoid duplicate title.

    @kring @lilleyse
    kring authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    eab0096 View commit details
    Browse the repository at this point in the history

  36. Fix links to 3D Tiles Next extensions

    @lilleyse
    lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    f34bd1a View commit details
    Browse the repository at this point in the history

  37. Describe binary data storage, remove prefix from FEATURE_ID_#, and de… 

    …fine semantics inline.
    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    fd7af90 View commit details
    Browse the repository at this point in the history

  38. Update other occurences of FEATURE_ID_# and binary data storage.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    06d4514 View commit details
    Browse the repository at this point in the history

  39. Update extensions/2.0/Vendor/EXT_feature_metadata/README.md 

    Co-authored-by: Peter Gagliardi <ptrgags@gmail.com>
    @donmccurdy @ptrgags @lilleyse
    2 people authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    149fe9b View commit details
    Browse the repository at this point in the history

  40. Clean up TODOs.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    2f3457d View commit details
    Browse the repository at this point in the history

  41. EXT_feature_metadata: Remove statistics, rename constant->offset and … 

    …divisor->repeat.
    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    dd38617 View commit details
    Browse the repository at this point in the history

  42. EXT_feature_metadata: Clarify scope and examples.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    8d3f5f4 View commit details
    Browse the repository at this point in the history

  43. Minor grammar tweak

    @ptrgags @lilleyse
    ptrgags authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    65f0bf0 View commit details
    Browse the repository at this point in the history

  44. Remove markdown generated from JSON schema. Flatten nested extensions.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    490eca1 View commit details
    Browse the repository at this point in the history

  45. Clean up.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    80404cf View commit details
    Browse the repository at this point in the history

  46. EXT_feature_metadata: Use disjoint enums for 'type' and 'componentType'.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    cd1502d View commit details
    Browse the repository at this point in the history

  47. EXT_feature_metadata: Clarify VECN and MATN dimensions.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e0560c2 View commit details
    Browse the repository at this point in the history

  48. EXT_feature_metadata: Simplify feature texture definition.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    cd26d4e View commit details
    Browse the repository at this point in the history

  49. EXT_feature_metadata: featureIds refactor

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    b7e0af1 View commit details
    Browse the repository at this point in the history

  50. EXT_feature_metadata: Updates for primitive extension schema.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c7151a4 View commit details
    Browse the repository at this point in the history

  51. typo fix

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    abf4a5a View commit details
    Browse the repository at this point in the history

  52. EXT_feature_metadata: Add 'featureTables' to node extension.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9111ea8 View commit details
    Browse the repository at this point in the history

  53. EXT_feature_metadata: Fix typo in feature texture example.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    1ead605 View commit details
    Browse the repository at this point in the history

  54. EXT_feature_metadata: Clarify channel index numbering and required pr… 

    …operty.
    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    56cf980 View commit details
    Browse the repository at this point in the history

  55. EXT_feature_metadata: Add 'noData' property.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    469a8e3 View commit details
    Browse the repository at this point in the history

  56. EXT_feature_metadata: Allow feature IDs outside [0, count - 1] as no-… 

    …feature indicators.
    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    8b27b43 View commit details
    Browse the repository at this point in the history

  57. EXT_feature_metadata: Disallow NaN, +Inf, -Inf.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    53cd729 View commit details
    Browse the repository at this point in the history

  58. EXT_feature_metadata: Clarify ENUM noData values.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    f14f703 View commit details
    Browse the repository at this point in the history

  59. EXT_feature_metadata: Apply wording feedback.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    fc60b45 View commit details
    Browse the repository at this point in the history

  60. EXT_feature_metadata: Clarify 'noData' length requirements.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    c55b1a2 View commit details
    Browse the repository at this point in the history

  61. EXT_feature_metadata: Add 'required' boolean.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    ef113b5 View commit details
    Browse the repository at this point in the history

  62. EXT_feature_metadata: Wording & clarity in class.property schema file.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    008bab9 View commit details
    Browse the repository at this point in the history

  63. EXT_feature_metadata: featureTables/featureTextures --> propertyTable… 

    …s/propertyTextures
    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    16ed8b8 View commit details
    Browse the repository at this point in the history

  64. EXT_feature_metadata: Remove unneeded disambiguation.

    @donmccurdy @lilleyse
    donmccurdy authored and lilleyse committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    ea7479e View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Rename EXT_feature_metadata → EXT_mesh_features

    @donmccurdy
    donmccurdy committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    6845f9c View commit details
    Browse the repository at this point in the history

  2. EXT_mesh_features: Rename remaining schema files.

    @donmccurdy
    donmccurdy committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    8e4fde4 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #20 from donmccurdy/ext-feature-metadata-v2.8 

    Rename EXT_feature_metadata → EXT_mesh_features
    @ptrgags
    ptrgags committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    3dae113 View commit details
    Browse the repository at this point in the history

  4. EXT_feature_metadata: Restrict string IDs to /a-zA-Z_/, include names… 

    … on feature tables and textures.
    @donmccurdy
    donmccurdy committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    3fd0830 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #18 from donmccurdy/ext-feature-metadata-v2.5 

    EXT_feature_metadata: Restrictions on string IDs, add property table and texture names
    @ptrgags
    ptrgags committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    fbc7956 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2021

  1. Merge branch 'main' into 3d-tiles-next

    @lilleyse
    lilleyse committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    de35cf3 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Document changes about noData

    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4c49601 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    35c9ba6 View commit details
    Browse the repository at this point in the history

  3. EXT_feature_metadata: Restore original EXT_feature_metadata for archive.

    @donmccurdy
    donmccurdy committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    9a0ef43 View commit details
    Browse the repository at this point in the history

  4. Add update about property type changes

    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    be50478 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #23 from donmccurdy/restore-ext-feature-metadata 

    Restore EXT_feature_metadata alongside EXT_mesh_features
    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    0e8d1bb View commit details
    Browse the repository at this point in the history

  6. Merge pull request #24 from CesiumGS/3d-tiles-next-rev 

    Consolidate staging branches
    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4ff20df View commit details
    Browse the repository at this point in the history

  7. Remove trailing periods in changelog for consistency

    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    39ba2fd View commit details
    Browse the repository at this point in the history

  8. Merge pull request #22 from CesiumGS/mesh-features-changelog 

    Update EXT_mesh_features changelog
    @ptrgags
    ptrgags committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    5e5cc98 View commit details
    Browse the repository at this point in the history