Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lane connector tool connects lanes even if there is only one lane. #617

Closed
kianzarrin opened this issue Jan 19, 2020 · 2 comments · Fixed by #706
Closed

Lane connector tool connects lanes even if there is only one lane. #617

kianzarrin opened this issue Jan 19, 2020 · 2 comments · Fixed by #706
Labels
BUG Defect detected confirmed Represents confirmed issue or bug LANE ROUTING Feature: Lane arrows / connectors
Milestone
11.3.0

Comments

@kianzarrin
Copy link
Collaborator

see #586 (comment)
In the picture bellow lane connector's stay in lane tool connects lanes even if there is only one lane . this is redundant.
Screenshot (312)

if there is only one lane, lane connector tool should ignore situations where there is only one lane in that directions.
@kianzarrin kianzarrin added BUG Defect detected triage Awaiting issue categorisation labels Jan 19, 2020
@kianzarrin kianzarrin mentioned this issue Jan 19, 2020
Merged
@originalfoo originalfoo added confirmed Represents confirmed issue or bug LANE ROUTING Feature: Lane arrows / connectors and removed triage Awaiting issue categorisation labels Jan 19, 2020
@originalfoo
Copy link
Member

Was this fixed in #586 or are futher changes required?

@kianzarrin
Copy link
Collaborator Author

@aubergine10 further changes required. Should be easy. But its low priority.

This was referenced Apr 1, 2020
Merged
Merged
kianzarrin added a commit that referenced this issue Apr 7, 2020
@kianzarrin
Merge pull request #706 from kianzarrin/703-laneconnector-quickfix
66ee727 
fixes #703 
- stay in lane on junctions (lanes do not crisscross). 
- When lane arithmetic does not match lanes connections are distributed evenly. the remainder goes to inner/other/center lanes depending  on circumstances.
- guide message is shown when nothing happens.
- changed shortcut key to CTRL+S (which conflicts with mod tools).
- I fixed a problem with stay in lane when stay in lane : when stayInLaneMode == None selected node markers disappeared.
- I added simple CanConnect() Condition for tracks which mostly solves #705. Asymmetrical tracks and mixed car/tram roads are still unsupported. 
fixes #617
- stay in lane does not connect if there is only one lane: #617
@originalfoo originalfoo added this to the 11.3.0 milestone Apr 7, 2020
krzychu124 added a commit that referenced this issue Apr 7, 2020
@krzychu124
Merge pull request #706 from kianzarrin/703-laneconnector-quickfix
f497723 
fixes #703
- stay in lane on junctions (lanes do not crisscross).
- When lane arithmetic does not match lanes connections are distributed evenly. the remainder goes to inner/other/center lanes depending  on circumstances.
- guide message is shown when nothing happens.
- changed shortcut key to CTRL+S (which conflicts with mod tools).
- I fixed a problem with stay in lane when stay in lane : when stayInLaneMode == None selected node markers disappeared.
- I added simple CanConnect() Condition for tracks which mostly solves #705. Asymmetrical tracks and mixed car/tram roads are still unsupported.
fixes #617
- stay in lane does not connect if there is only one lane: #617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Defect detected confirmed Represents confirmed issue or bug LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Milestone
11.3.0
Development

Successfully merging a pull request may close this issue.

Lane Connector tool - Quick setup kianzarrin/Cities-Skylines-Traffic-Manager-President-Edition
2 participants
@originalfoo @kianzarrin