Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Shift+Click speed limit to entire roundabout #869

Closed
kianzarrin opened this issue Apr 27, 2020 · 3 comments · Fixed by #920
Closed

Apply Shift+Click speed limit to entire roundabout #869

kianzarrin opened this issue Apr 27, 2020 · 3 comments · Fixed by #920
Labels
feature A new distinct feature
Milestone

Comments

@kianzarrin
Copy link
Collaborator

@thebugfixnet I figured out that the Speed-Limit function works within round-abouts in the same way they do on normal roads.
On normal roads with Shift-Klick the speed limit is assigned from one junction to the next. I can understand this as in real world also the speed limits at the next crossing may be different. So this behavior i was ecpexting.
But on roundabouts in my opinion there should be the logic to set the speed limit for the whole roundabout street with Shift-Klick. This is the way ot is in real i think. Additionally the super function of automated lower speed limits on roundabouts do it for the whole roundabout road. To be consistend to this function it would be good to handle it in the same way for the speed-limit function.
image

So if it is a roundabout, I apply to all roundabout segments. Otherwise I apply between to junctions.

@kianzarrin kianzarrin added feature A new distinct feature triage Awaiting issue categorisation labels Apr 27, 2020
@originalfoo
Copy link
Member

Yes, that would be nice to have.

@originalfoo originalfoo changed the title speed limit tool "apply to all segments option" should cover the whole roundaobut Apply Shift+Click speed limit to entire roundabout Apr 27, 2020
@kianzarrin
Copy link
Collaborator Author

I wrote the code.
Screenshot (933)
Screenshot (932)
ill do more testing.

@originalfoo
Copy link
Member

Love it!!

kianzarrin added a commit that referenced this issue Jun 12, 2020
#869: Apply Shift+Click speed limit to entire roundabout
kianzarrin added a commit that referenced this issue Jun 12, 2020
#869: Apply Shift+Click speed limit to entire roundabout
@originalfoo originalfoo added this to the 11.6.0 milestone Jun 13, 2020
krzychu124 added a commit that referenced this issue Nov 14, 2020
#869: Apply Shift+Click speed limit to entire roundabout

(cherry picked from commit ec3227d)
@originalfoo originalfoo modified the milestones: 11.6.0, 11.5.1 Jan 19, 2022
@originalfoo originalfoo removed the triage Awaiting issue categorisation label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new distinct feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants