Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Shift+Click speed limit to entire roundabout #920

Merged
merged 8 commits into from
Jun 12, 2020
Merged

Apply Shift+Click speed limit to entire roundabout #920

merged 8 commits into from
Jun 12, 2020

Conversation

kianzarrin
Copy link
Collaborator

image
fixes #869

The GIF below demonstrates what happens in the case of lane count mismatch
ezgif com-optimize(2)

The road names "inverted" or "not inverted" shows if the invert flag of the segment. I have tested with both flags in the GIF above.

PS: I used auto code cleanup. Please use ignore white spaces to make the code review easier for yourself :)

@originalfoo
Copy link
Member

Looking forward to testing this!

@originalfoo originalfoo added this to the 11.6.0 milestone Jun 3, 2020
@originalfoo originalfoo added the SPEED LIMITS Feature: Speed limits label Jun 3, 2020
kvakvs
kvakvs reviewed Jun 7, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with how the code is done
TODO: Actual play test :)

originalfoo
originalfoo approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Particularly like how you deal with differing lane counts.

LGTM 👍

@originalfoo
Copy link
Member

@kvakvs did you get chance to test this in-game yet?

kvakvs
kvakvs approved these changes Jun 10, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ingame.
Loving it.

@kianzarrin
Copy link
Collaborator Author

I forgot to test with LHT

@kianzarrin
Copy link
Collaborator Author

image
works on LHT too :)

@kianzarrin kianzarrin merged commit ec3227d into master Jun 12, 2020
@kianzarrin kianzarrin deleted the 869-speedlimit-tool-roundabout branch June 12, 2020 02:58
@originalfoo
Copy link
Member

Yup, I tested on LHT and couldn't break it. :)

kianzarrin added a commit that referenced this pull request Jun 12, 2020
@kianzarrin
Apply Shift+Click speed limit to entire roundabout (#920)
8576410 
#869: Apply Shift+Click speed limit to entire roundabout
krzychu124 added a commit that referenced this pull request Jun 13, 2020
@krzychu124
Revert "Apply Shift+Click speed limit to entire roundabout (#920)"
2a65acb 
This reverts commit 8576410.
krzychu124 added a commit that referenced this pull request Nov 14, 2020
@krzychu124
Apply Shift+Click speed limit to entire roundabout (#920)
37c5d02 
#869: Apply Shift+Click speed limit to entire roundabout

(cherry picked from commit ec3227d)
@originalfoo originalfoo modified the milestones: 11.6.0, 11.5.1 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@krzychu124 krzychu124 Awaiting requested review from krzychu124

Assignees

@kianzarrin kianzarrin

Labels
SPEED LIMITS Feature: Speed limits
Projects
None yet
Milestone
11.5.1
Development

Successfully merging this pull request may close these issues.

Apply Shift+Click speed limit to entire roundabout
3 participants
@kianzarrin @originalfoo @kvakvs