Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (applications): add git+ssh URL in local config data #633

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Nov 22, 2023

It's done when app is created or its informations queried.
It will only work for newly linked/created apps

Fix #619

@davlgd davlgd self-assigned this Nov 22, 2023
@davlgd davlgd requested a review from a team as a code owner November 22, 2023 10:24
@davlgd davlgd changed the title Add git+ssh URL feat: add git+ssh URL Dec 28, 2023
@davlgd davlgd changed the title feat: add git+ssh URL feat (applications): add git+ssh URL in local config data Dec 28, 2023
* we add the git+ssh URL on clever link
* if the .clever.json doesn't have the git+ssh URL, we infer it from the
  HTTPS URL

Closes #619
Copy link

🔎 A preview has been automatically published:

  • 🐧 linux b940d18c1baa38b76be82b913d7f9c4bc3c3de7bb3363d250ec8b8155ca23afa
  • 🍏 macos f92990bc97361e8f2566287135f30b25ec5dc3bca2b3e65eea94fa7285222722
  • 🪟 win bd3d47e55b9009601069e2cb2dae59a33a9f10d923e1fb923e8cbb114fb3bec4

This preview will be deleted once this PR is closed.

@hsablonniere hsablonniere merged commit 763dbbc into master Jan 25, 2024
5 checks passed
@hsablonniere hsablonniere deleted the davlgd-git-ssh-url branch January 25, 2024 16:17
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clever applications: provide the SSH deployment URL
4 participants