Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect 'logs_created' internal metric #2604

Merged
merged 8 commits into from
Apr 12, 2024
Merged

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Mar 29, 2024

Description

Part of https://datadoghq.atlassian.net/browse/AIT-4125

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Merging #2604 (a2e7477) into master (7169ff4) will decrease coverage by 10.35%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2604       +/-   ##
=============================================
- Coverage     75.52%   65.18%   -10.35%     
  Complexity     2603     2603               
=============================================
  Files           242      242               
  Lines         27277    27267       -10     
  Branches        985      985               
=============================================
- Hits          20601    17774     -2827     
- Misses         6151     8968     +2817     
  Partials        525      525               
Flag Coverage Δ
appsec-extension 69.01% <ø> (ø)
tracer-extension 78.71% <100.00%> (-0.01%) ⬇️
tracer-php 47.09% <ø> (-27.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/ddtrace.c 73.25% <100.00%> (-0.07%) ⬇️
ext/sidecar.h 70.00% <100.00%> (+7.50%) ⬆️
ext/telemetry.c 98.91% <100.00%> (+0.08%) ⬆️

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7169ff4...a2e7477. Read the comment docs.

ext/telemetry.c Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024

Benchmarks

Benchmark execution time: 2024-04-12 15:26:18

Comparing candidate commit 5efc1b3 in PR branch lv/metric-logs_created with baseline commit 4780cb9 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+19.230µs; +22.070µs] or [+10.935%; +12.551%]

@iamluc iamluc force-pushed the lv/metric-logs_created branch 2 times, most recently from 73edec8 to 762d1e0 Compare April 2, 2024 10:11
@iamluc iamluc marked this pull request as ready for review April 2, 2024 11:46
@iamluc iamluc requested a review from a team as a code owner April 2, 2024 11:46
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, thanks :-)

ext/telemetry.c Outdated Show resolved Hide resolved
@bwoebi bwoebi merged commit e721e34 into master Apr 12, 2024
602 of 606 checks passed
@bwoebi bwoebi deleted the lv/metric-logs_created branch April 12, 2024 17:35
@github-actions github-actions bot added this to the 0.99.0 milestone Apr 12, 2024
@bwoebi bwoebi modified the milestones: 0.99.0, 1.0.0beta1 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants