Collect the 'logs_created' metric for the sidecar #390
+100
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamluc
force-pushed
the
lv/sidecar-logs_created-metric
branch
from
a029c37
to
b9dbe10
Compare
iamluc
force-pushed
the
lv/sidecar-logs_created-metric
branch
from
b9dbe10
to
582548a
Compare
bwoebi
reviewed
Apr 12, 2024
bwoebi
reviewed
Apr 12, 2024
bwoebi
reviewed
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Count the number of logs created by the sidecar and send the data as a self-telemetry metric.
Part of https://datadoghq.atlassian.net/browse/AIT-4125
Similar to what is done in dd-trace-php (DataDog/dd-trace-php#2604)
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
For Reviewers
@DataDog/security-design-and-guidance.