-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the active service/env/version for metric tags #2742
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2742 +/- ##
============================================
- Coverage 79.52% 77.96% -1.57%
Complexity 2216 2216
============================================
Files 201 227 +26
Lines 22595 26634 +4039
Branches 0 989 +989
============================================
+ Hits 17969 20764 +2795
- Misses 4626 5344 +718
- Partials 0 526 +526
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-07-03 23:07:07 Comparing candidate commit b719477 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOOverhead
scenario:TraceSerializationBench/benchSerializeTrace
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expect the issue with property_env
, 👍
ext/sidecar.c
Outdated
zend_string *env = get_DD_ENV(); | ||
if (span) { | ||
env = ddtrace_convert_to_str(&span->property_version); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property_env
.
Also get_DD_ENV();
could be called in the "else" branch to avoid an unnecessary call when span is not null. 🤷
Same for get_DD_VERSION()
below
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
b719477
to
f238cd4
Compare
I just noticed that while testing live-debugger metrics - the actual service still ought to be reported.
It's just php-dogstatsd which isn't aware of ddtrace state.