Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env&version tags leaking in metrics #2745

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jul 5, 2024

Follow-up to #2742.

@bwoebi bwoebi requested a review from a team as a code owner July 5, 2024 09:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.95%. Comparing base (4ab0eb7) to head (a51c26c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2745      +/-   ##
============================================
- Coverage     77.99%   77.95%   -0.05%     
  Complexity     2216     2216              
============================================
  Files           227      227              
  Lines         26635    26637       +2     
  Branches        989      989              
============================================
- Hits          20775    20765      -10     
- Misses         5334     5346      +12     
  Partials        526      526              
Flag Coverage Δ
appsec-extension 69.19% <ø> (ø)
tracer-extension 78.80% <50.00%> (+<0.01%) ⬆️
tracer-php 80.54% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/sidecar.c 87.40% <50.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab0eb7...a51c26c. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Jul 5, 2024

Benchmarks

Benchmark execution time: 2024-07-05 10:08:41

Comparing candidate commit a51c26c in PR branch bob/fix-env&version-tags with baseline commit 4ab0eb7 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelOverhead

  • 🟥 execution_time [+110.542µs; +218.118µs] or [+4.116%; +8.121%]

@PROFeNoM PROFeNoM merged commit ec095eb into master Jul 5, 2024
660 of 668 checks passed
@PROFeNoM PROFeNoM deleted the bob/fix-env&version-tags branch July 5, 2024 11:43
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants