Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pyproject exclusion and ddev #14257

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Mar 29, 2023

What does this PR do?

ddev uses it's own pyproject.toml

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

2 similar comments
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@steveny91 steveny91 mentioned this pull request Mar 29, 2023
5 tasks
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

This was referenced Mar 29, 2023
@steveny91 steveny91 added changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA labels Mar 29, 2023
@steveny91 steveny91 marked this pull request as ready for review March 29, 2023 18:56
@steveny91 steveny91 requested a review from a team as a code owner March 29, 2023 18:56
* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
@steveny91 steveny91 requested review from a team as code owners March 30, 2023 16:33
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

steveny91 added a commit that referenced this pull request Mar 30, 2023
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Mar 30, 2023
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Mar 30, 2023
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Apr 11, 2023
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Apr 11, 2023
* replace flak8 and isort with ruff

* Ignore F401 for unused imports used in typings (#14213)

* add comment

* Fix all C linting errors (#14214)

* ignore existing F401

* fix all C linting errors

* resolve merge conflicts

* Fix misc linting issues (#14215)

* fix misc issues

* Ignore minor linting issues (#14216)

* ignore minor issues

* change flake8 to ruff (#14223)

* licence sync

* fix pyproject

* fix pyproject exclusion and ddev (#14257)

* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere

* change target version to py38

* add small note
github-actions bot pushed a commit that referenced this pull request Apr 11, 2023
* replace flak8 and isort with ruff

* Ignore F401 for unused imports used in typings (#14213)

* add comment

* Fix all C linting errors (#14214)

* ignore existing F401

* fix all C linting errors

* resolve merge conflicts

* Fix misc linting issues (#14215)

* fix misc issues

* Ignore minor linting issues (#14216)

* ignore minor issues

* change flake8 to ruff (#14223)

* licence sync

* fix pyproject

* fix pyproject exclusion and ddev (#14257)

* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere

* change target version to py38

* add small note b7c15a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment