Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final linting fixes #14266

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Final linting fixes #14266

merged 3 commits into from
Mar 30, 2023

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Mar 29, 2023 •
edited
Loading

What does this PR do?

Fix specific formatting and linting issues that were missed

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

This was referenced Mar 29, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@steveny91 Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #14266 (9673c6f) into sy/implement-ruff-1b (fe4af7b) will decrease coverage by 1.41%.
The diff coverage is 94.11%.

Flag Coverage Δ
active_directory 100.00% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
amazon_msk 89.07% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.43% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 92.54% <ø> (ø)
azure_iot_edge 82.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
calico 83.33% <ø> (ø)
cilium 75.34% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 95.98% <ø> (ø)
cockroachdb 90.96% <ø> (ø)
consul 91.64% <ø> (ø)
coredns 94.54% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 80.86% <100.00%> (-8.44%) ⬇️
datadog_checks_dev 79.96% <100.00%> (-2.53%) ⬇️
datadog_checks_downloader 80.48% <100.00%> (ø)
datadog_cluster_agent 90.00% <ø> (ø)
ddev 98.64% <100.00%> (ø)
directory 96.50% <ø> (ø)
disk 89.64% <ø> (ø)
dns_check 93.90% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 80.92% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
external_dns 89.09% <ø> (ø)
foundationdb 78.50% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
gunicorn 92.10% <ø> (ø)
hazelcast 92.39% <ø> (ø)
http_check 95.81% <ø> (ø)
ibm_i 81.95% <ø> (ø)
impala 97.97% <ø> (ø)
istio 77.43% <ø> (ø)
kube_apiserver_metrics 97.95% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.96% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.35% <ø> (ø)
marathon 83.12% <ø> (ø)
mcache 93.50% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.43% <ø> (-0.56%) ⬇️
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack 51.45% <ø> (+0.26%) ⬆️
openstack_controller 91.12% <ø> (+<0.01%) ⬆️
php_fpm 90.25% <ø> (ø)
prometheus 94.17% <ø> (ø)
pulsar 100.00% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
silk 93.51% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teradata 94.24% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twistlock 79.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@steveny91 steveny91 added changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA labels Mar 29, 2023
@steveny91 steveny91 changed the title linting fixes Final linting fixes Mar 29, 2023
@steveny91 steveny91 marked this pull request as ready for review March 29, 2023 18:55
@steveny91 steveny91 requested review from a team as code owners March 29, 2023 18:55
@steveny91 steveny91 merged commit 09a7a60 into sy/implement-ruff-1b Mar 30, 2023
@steveny91 steveny91 deleted the sy/implement-ruff-1c branch March 30, 2023 16:33
steveny91 added a commit that referenced this pull request Mar 30, 2023
@steveny91
add skip QAs to template files (#14258)
6ee3ad0 
* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Mar 30, 2023
@steveny91
fix pyproject exclusion and ddev (#14257)
f4a182a 
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Mar 30, 2023
@steveny91
fix pyproject exclusion and ddev (#14257)
f68a183 
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Mar 30, 2023
@steveny91
fix pyproject exclusion and ddev (#14257)
c8df064 
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Mar 30, 2023
@steveny91
fix pyproject exclusion and ddev (#14257)
254aeef 
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Apr 11, 2023
@steveny91
fix pyproject exclusion and ddev (#14257)
2626f8e 
* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere
steveny91 added a commit that referenced this pull request Apr 11, 2023
@steveny91
Replace flake8 and isort with Ruff (#14212)
b7c15a6 
* replace flak8 and isort with ruff

* Ignore F401 for unused imports used in typings (#14213)

* add comment

* Fix all C linting errors (#14214)

* ignore existing F401

* fix all C linting errors

* resolve merge conflicts

* Fix misc linting issues (#14215)

* fix misc issues

* Ignore minor linting issues (#14216)

* ignore minor issues

* change flake8 to ruff (#14223)

* licence sync

* fix pyproject

* fix pyproject exclusion and ddev (#14257)

* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere

* change target version to py38

* add small note
github-actions bot pushed a commit that referenced this pull request Apr 11, 2023
@steveny91
Replace flake8 and isort with Ruff (#14212)
67de58d 
* replace flak8 and isort with ruff

* Ignore F401 for unused imports used in typings (#14213)

* add comment

* Fix all C linting errors (#14214)

* ignore existing F401

* fix all C linting errors

* resolve merge conflicts

* Fix misc linting issues (#14215)

* fix misc issues

* Ignore minor linting issues (#14216)

* ignore minor issues

* change flake8 to ruff (#14223)

* licence sync

* fix pyproject

* fix pyproject exclusion and ddev (#14257)

* fix pyproject exclusion and ddev

* revert a change to the incorrect file

* revert a change to the incorrect file

* add skip QAs to template files (#14258)

* fix

* Final linting fixes (#14266)

* linting fixes

* linting fixes

* fix vsphere

* change target version to py38

* add small note b7c15a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
base_package changelog/no-changelog ddev dev_package dev/tooling downloader integration/cloudera integration/datadog_checks_tests_helper integration/envoy integration/mongo integration/openshift integration/openstack_controller integration/openstack integration/rabbitmq integration/riakcs integration/snmp integration/ssh_check integration/vertica integration/vsphere qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveny91 @yzhan289