Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class "Homme::SimulationParams" has no member "moisture" #6635

Closed
mahf708 opened this issue Sep 22, 2024 · 3 comments · Fixed by #6645
Closed

class "Homme::SimulationParams" has no member "moisture" #6635

mahf708 opened this issue Sep 22, 2024 · 3 comments · Fixed by #6645
Labels
bug EAMxx PRs focused on capabilities for EAMxx HOMME

Comments

@mahf708
Copy link
Contributor

mahf708 commented Sep 22, 2024

PR #6594 broke eamxx when it was merged.

example errors:

/global/u2/e/e3smtest/jenkins/workspace/ACME_perlmutter_e3sm_gpucxx_gnugpu/E3SM/components/eamxx/src/dynamics/homme/eamxx_homme_process_interface.cpp(822): error: class "Homme::SimulationParams" has no member "moisture"
@mahf708 mahf708 added bug HOMME EAMxx PRs focused on capabilities for EAMxx labels Sep 22, 2024
@oksanaguba
Copy link
Contributor

thanks, i did not realize scream is running from e3sm repo. fixes are here https://github.com/E3SM-Project/E3SM/pull/6636/files .

@mahf708 mahf708 mentioned this issue Sep 22, 2024
Closed
@mahf708
Copy link
Contributor Author

mahf708 commented Sep 23, 2024

Yeah, we even run some stuff interactively on github. For example, see this https://github.com/E3SM-Project/E3SM/actions/runs/10985455421, which fail if we run them now (like I just did). However, that same exact tests pass in your PR #6636...

@mahf708
Copy link
Contributor Author

mahf708 commented Sep 23, 2024 •
edited
Loading

The tests didn't run on your older PR because eam/elm/eamxx files weren't edited in your older PR... maybe we should enable EAM/EAMxx tests when homme is touched...

@mahf708 mahf708 mentioned this issue Sep 23, 2024
Open
@ambrad ambrad mentioned this issue Sep 24, 2024
Merged
ambrad added a commit that referenced this issue Sep 24, 2024
@ambrad
Merge branch 'ambrad/hommexx/fix-E3SM-SCREAMv1-build' into next (PR #…
3a4787f 
…6645)

Hommexx: Temporarily work around some EAMxx-Hommexx incompatibilities.

These are due to PR #6594 and break the E3SM-repo EAMxx build. Once the SCREAM
and E3SM repos are unified, we can back out these workarounds.

The workarounds are isolated to components/homme, keeping the commit separation
of components/eamxx (SCREAM repo) and components/homme (E3SM repo) clean.

Fixes #6635.

[BFB]
@ambrad ambrad closed this as completed in fc02007 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug EAMxx PRs focused on capabilities for EAMxx HOMME
Projects
None yet
Milestone
No milestone
2 participants
@oksanaguba @mahf708