Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hommexx: Temporarily work around some EAMxx-Hommexx incompatibilities. #6645

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Hommexx: Temporarily work around some EAMxx-Hommexx incompatibilities. #6645

merged 1 commit into from
Sep 25, 2024

Conversation

ambrad
Copy link
Member

@ambrad ambrad commented Sep 24, 2024 •
edited
Loading

These are due to PR #6594 and break the E3SM-repo EAMxx build. Once the SCREAM and E3SM repos are unified, we can back out these workarounds.

The workarounds are isolated to components/homme, keeping the commit separation of components/eamxx (SCREAM repo) and components/homme (E3SM repo) clean.

Fixes #6635.

[BFB]

@ambrad
Hommexx: Temporarily work around some EAMxx-Hommexx incompatibilities.
2413f42 
These are due to PR E3SM-Project#6594 and break the E3SM-repo EAMxx build. Once the SCREAM
and E3SM repos are unified, we can back out these workarounds.

The workarounds are isolated to components/homme, keeping the commit separation
of components/eamxx (SCREAM repo) and components/homme (E3SM repo) clean.
@ambrad
Copy link
Member Author

ambrad commented Sep 24, 2024

This is the alternative approach I proposed. Chrysalis is backed up with e3smtest jobs, so I might not get this into next today.

@ambrad ambrad mentioned this pull request Sep 24, 2024
Closed
@ambrad ambrad self-assigned this Sep 24, 2024
@ambrad ambrad added HOMME EAMxx PRs focused on capabilities for EAMxx labels Sep 24, 2024
@ambrad
Copy link
Member Author

ambrad commented Sep 24, 2024

On Chrysalis, ERS_Ld5_P4.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.chrysalis_intel.eamxx-prod fails with

ABORTING WITH ERROR: NaNs detected in repro sum input

near or during initialization. However, it fails exactly this same way with git checkout ac05a69699^, i.e., before #6594. Thus, I will disregard the run failure but note that the build now succeeds.

@rljacob
Copy link
Member

rljacob commented Sep 24, 2024

Can you see if ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu passes?

@mahf708
Copy link
Contributor

mahf708 commented Sep 24, 2024 •
edited
Loading

Can you see if ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu passes?

This passed

SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu (Overall: PASS) 

20240924_125521_nymj2l: 1 test
  SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu (Overall: PASS) details:
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu CREATE_NEWCASE
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu XML
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu SETUP
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu SHAREDLIB_BUILD time=119
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu MODEL_BUILD time=603
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu SUBMIT
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu RUN time=60
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu MEMLEAK insufficient data for memleak test
    PASS SMS.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.pm-gpu_gnugpu SHORT_TERM_ARCHIVER

ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu (Overall: PASS) 

20240924_142813_wods39: 1 test
  ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu (Overall: PASS) details:
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu CREATE_NEWCASE
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu XML
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu SETUP
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu SHAREDLIB_BUILD time=219
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu MODEL_BUILD time=1127
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu SUBMIT
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu RUN time=63
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu COMPARE_base_rest
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu MEMLEAK insufficient data for memleak test
    PASS ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu SHORT_TERM_ARCHIVER

@ambrad
Copy link
Member Author

ambrad commented Sep 24, 2024

homme_integration and e3sm_developer pass on Chrysalis. I will merge to next.

ambrad added a commit that referenced this pull request Sep 24, 2024
@ambrad
Merge branch 'ambrad/hommexx/fix-E3SM-SCREAMv1-build' into next (PR #…
3a4787f 
…6645)

Hommexx: Temporarily work around some EAMxx-Hommexx incompatibilities.

These are due to PR #6594 and break the E3SM-repo EAMxx build. Once the SCREAM
and E3SM repos are unified, we can back out these workarounds.

The workarounds are isolated to components/homme, keeping the commit separation
of components/eamxx (SCREAM repo) and components/homme (E3SM repo) clean.

Fixes #6635.

[BFB]
@ambrad ambrad merged commit fc02007 into E3SM-Project:master Sep 25, 2024
5 checks passed
@ambrad
Copy link
Member Author

ambrad commented Sep 25, 2024

@mahf708 this is merged to master now, so when you get a chance, you can re-enable the F-cases in the github CI. Thanks for disabling them for two days.

@ambrad ambrad added the BFB PR leaves answers BFB label Sep 25, 2024
@mahf708
Copy link
Contributor

mahf708 commented Sep 25, 2024 •
edited
Loading

@mahf708 this is merged to master now, so when you get a chance, you can re-enable the F-cases in the github CI. Thanks for disabling them for two days.

Great!

Btw, in the future, we will run the F cases whenever homme is touched, this is being added here: https://github.com/E3SM-Project/E3SM/pull/6640/files#diff-df452f774adf857e45ddde63b278e3c8903922048d9aa680e37f428c6977aa9aR13. That will help us catch this type of thing ahead of time.

@rljacob
Copy link
Member

rljacob commented Sep 26, 2024

Replaces #6636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartgol bartgol bartgol approved these changes

@oksanaguba oksanaguba oksanaguba approved these changes

Assignees

@ambrad ambrad

Labels
BFB PR leaves answers BFB EAMxx PRs focused on capabilities for EAMxx HOMME
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

class "Homme::SimulationParams" has no member "moisture"
5 participants
@ambrad @rljacob @mahf708 @bartgol @oksanaguba