Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to independently version docker images #1166

Merged
merged 7 commits into from
Aug 21, 2018
Merged

Add support to independently version docker images #1166

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
edc8939
Add docker-image version maintainer file
mrrobot47 Aug 10, 2018
c42f0bc
Add function to get versions
mrrobot47 Aug 10, 2018
3f1a0c4
Get image version from utils
mrrobot47 Aug 10, 2018
f7ae513
Get image versions in migrations from utils
mrrobot47 Aug 21, 2018
5a02703
Update json handling validations
mrrobot47 Aug 21, 2018
5b41f5a
Add remaining images
mrrobot47 Aug 21, 2018
06943aa
Merge branch 'develop-v4' into feature/docker-img-versioning
mrrobot47 Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions img-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"easyengine/mailhog": "v4.0.0-beta.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be using this docker image version from this file to all the places now. https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L39

https://github.com/EasyEngine/site-wp-command/blob/develop/src/Site_WP_Docker.php#L128

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will updated in https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L39

For site-command and site-wp-command:
EasyEngine/site-command#95
EasyEngine/site-type-wp#15

"easyengine/mariadb": "v4.0.0-beta.5",
"easyengine/nginx-proxy": "v4.0.0-beta.5",
"easyengine/nginx": "v4.0.0-beta.5",
"easyengine/php": "v4.0.0-beta.5",
"easyengine/phpmyadmin": "v4.0.0-beta.5",
"easyengine/postfix": "v4.0.0-beta.5",
"easyengine/redis": "v4.0.0-beta.5"
}
3 changes: 2 additions & 1 deletion php/site-utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ function init_checks() {
EE::error( 'Cannot create/start proxy container. Please make sure port 80 and 443 are free.' );
} else {
$EE_CONF_ROOT = EE_CONF_ROOT;
$ee_proxy_command = "docker run --name $proxy_type -e LOCAL_USER_ID=`id -u` -e LOCAL_GROUP_ID=`id -g` --restart=always -d -p 80:80 -p 443:443 -v $EE_CONF_ROOT/nginx/certs:/etc/nginx/certs -v $EE_CONF_ROOT/nginx/dhparam:/etc/nginx/dhparam -v $EE_CONF_ROOT/nginx/conf.d:/etc/nginx/conf.d -v $EE_CONF_ROOT/nginx/htpasswd:/etc/nginx/htpasswd -v $EE_CONF_ROOT/nginx/vhost.d:/etc/nginx/vhost.d -v /var/run/docker.sock:/tmp/docker.sock:ro -v $EE_CONF_ROOT:/app/ee4 -v /usr/share/nginx/html easyengine/nginx-proxy:v" . EE_VERSION;
$img_versions = EE\Utils\get_image_versions();
$ee_proxy_command = "docker run --name $proxy_type -e LOCAL_USER_ID=`id -u` -e LOCAL_GROUP_ID=`id -g` --restart=always -d -p 80:80 -p 443:443 -v $EE_CONF_ROOT/nginx/certs:/etc/nginx/certs -v $EE_CONF_ROOT/nginx/dhparam:/etc/nginx/dhparam -v $EE_CONF_ROOT/nginx/conf.d:/etc/nginx/conf.d -v $EE_CONF_ROOT/nginx/htpasswd:/etc/nginx/htpasswd -v $EE_CONF_ROOT/nginx/vhost.d:/etc/nginx/vhost.d -v /var/run/docker.sock:/tmp/docker.sock:ro -v $EE_CONF_ROOT:/app/ee4 -v /usr/share/nginx/html easyengine/nginx-proxy:" . $img_versions['easyengine/nginx-proxy'];


if ( EE::docker()::boot_container( $proxy_type, $ee_proxy_command ) ) {
Expand Down
10 changes: 10 additions & 0 deletions php/utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,3 +1545,13 @@ function get_callable_name( callable $callable ) {
return 'unknown';
}
}

/**
* Function to get the docker image versions stored in img-versions.json file.
*
* @return array Docker image versions.
*/
function get_image_versions() {

return json_decode( file_get_contents( EE_ROOT . '/img-versions.json' ), true );
}