Funder fees #4509
Merged
Funder fees #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/funder-fees
branch
from
1a1a9f8
to
d2ab0b1
Compare
| } | ||
| json_array_end(req->js); | ||
|
|
||
| plugin_log(cmd->plugin, LOG_DBG, | ||
| "calling `signpsbt` for channel %s", | ||
| "calling `signpsbt` for channel %s for %zu input%s", |
There was a problem hiding this comment.
Maybe there is missing space in input%s?
There was a problem hiding this comment.
The last %s is for gramamtical reasons. It'll print "1 input" or "2 inputs".
There was a problem hiding this comment.
My big mistake, sorry I only take into consideration the line and not the meaning! (bad job vincent :) ).
vincenzopalazzo
requested changes
May 5, 2021
vincenzopalazzo
approved these changes
May 5, 2021
Useful for asserting how many inputs we're contributing
if the utxo can't pay for its own fees, dont put it in the tx Changelog-Changed: JSONRPC: fundpsbt will not include UTXOs that aren't economic (can't pay for their own fees), unless 'all'
Adjust our total available funds downward, to account for the fees we'll be charged to spend them.
Make sure that 100% available actually puts in 100% of what we can add (note that this isn't 'all' -- we don't include uneconomic utxos)
If we don't put funds into a channel, say why in the logs. Should make it a bit easier to figure out what's going on.
niftynei
force-pushed
the
nifty/funder-fees
branch
from
929a418
to
f56380a
Compare
If l2 didn't get FUNDING_LOCKED from l1 before it disconnected, it won't be in state CHANNELD_NORMAL: it will be in DUALOPEND_AWAITING_LOCKIN. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
Ack 1d1d64e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not accounting for our fees when we're calculating the total available for funding bit @fiatjaf
If a utxo isn't economical, we shouldn't add it to the transaction.