Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funder fees #4509

Merged
merged 6 commits into from
May 22, 2021
Merged

Funder fees #4509

merged 6 commits into from
May 22, 2021

Commits on May 12, 2021

  1. funder: add count of utxos we're signing to the logs

    Useful for asserting how many inputs we're contributing
    niftynei committed May 12, 2021
    Configuration menu
    Copy the full SHA
    a8a9a1e View commit details
    Browse the repository at this point in the history
  2. fundpsbt: dont add utxos that are a net-loss

    if the utxo can't pay for its own fees, dont put it in the tx
    
    Changelog-Changed: JSONRPC: fundpsbt will not include UTXOs that aren't economic (can't pay for their own fees), unless 'all'
    niftynei committed May 12, 2021
    Configuration menu
    Copy the full SHA
    4f95774 View commit details
    Browse the repository at this point in the history
  3. funder: subtract the fee of the utxo from the available amount

    Adjust our total available funds downward, to account for the fees we'll
    be charged to spend them.
    niftynei committed May 12, 2021
    Configuration menu
    Copy the full SHA
    b827df1 View commit details
    Browse the repository at this point in the history
  4. funder: test for adding utxos, calculating total available

    Make sure that 100% available actually puts in 100% of what we can add
    (note that this isn't 'all' -- we don't include uneconomic utxos)
    niftynei committed May 12, 2021
    Configuration menu
    Copy the full SHA
    db685ef View commit details
    Browse the repository at this point in the history
  5. funder: print reason that we don't contribute funds

    If we don't put funds into a channel, say why in the logs. Should make
    it a bit easier to figure out what's going on.
    niftynei committed May 12, 2021
    Configuration menu
    Copy the full SHA
    f56380a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. pytest: fix flake in test_reconnect_no_update

    If l2 didn't get FUNDING_LOCKED from l1 before it disconnected, it
    won't be in state CHANNELD_NORMAL: it will be in DUALOPEND_AWAITING_LOCKIN.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    rustyrussell authored and niftynei committed May 17, 2021
    Configuration menu
    Copy the full SHA
    1d1d64e View commit details
    Browse the repository at this point in the history