New calsses:air temperature amplitude #432
Comments
celineaubert
changed the title
KrishnaTO
added a commit
to KrishnaTO/envo
that referenced
this issue
Dec 23, 2021
EnvironmentOntology#432 Added classes in EA pattern Added classes: - soil water infiltration speed - topsoil thickness - soil drainage speed - air temperature amplitude
pbuttigieg
added a commit
that referenced
this issue
Aug 10, 2022
* Added CC pattern classes (desc for issues list) Addresses issues #369 #370 #371 #372 #373 #374 #401 #402 #403 #404 #405 #406 #407 #408 #409 #410 #411 #412 #414 * Added CC pattern class per issue #394 Ran dosdp run per previous commit with current class substitution. * Revert "Added CC pattern class per issue #394" This reverts commit e74d8aa. * Revert "Added CC pattern classes (desc for issues list)" This reverts commit 0064be2. * Rerun pattern add using make recipe * Revert "Rerun pattern add using make recipe" This reverts commit d8e1124. * Added EAL and CC pattern-based classes See issues from list for classes added: Chemical Concentration [CC] closes #369 closes #394 closes #401 closes #402 closes #403 closes #404 closes #405 closes #406 closes #407 closes #408 closes #409 closes #410 closes #411 closes #412 closes #414 Entity Attribute Location [EAL] closes #367 closes #370 closes #371 closes #372 closes #373 closes #374 closes #396 closes #413 closes #429 * #368 [EA] Added class 'color of soil' * #360 Added class 'hours of sunshine' Corrected previous commit's EAL pattern ids Imported pato term: duration Added class 'hours of sunshine' using EA pattern and revised label to correct string * #366 Add class 'pressure of vapour' * #361 [EA] Added class 'runoff volume' closes #361 * #353,#354,#355 [EA] Added 'evaporation', 'evapotranspiration', 'rain' volumes * Added classes for water infiltration Added classes: - water infiltration - soil water infiltration * #415 added classes for exchangeable potassium Added classes: - exchangeable potassium - exchangeable ion * #417 added class 'residual water' * Added class 'exchangeable calcium' * Added class 'cation exchange capacity' * update DL 'exchangeable ion' relation to 'CEC' * #422 added class 'percentage base saturation' * #415 #417 #418 Added CC patterns Added patterns for classes: - exchangeable potassium content in soil - residual water content in soil - exchangeable calcium content in soil * Update 'water infiltration' DL * #395 #398 #420 #432 Added classes in EA pattern Added classes: - soil water infiltration speed - topsoil thickness - soil drainage speed - air temperature amplitude * run robot dosdp patterns for CC & EA Imported PATO term corrected EA IRI * regenerating pato_import.owl * fixing semantics for manually added classes in #1228 * fixing unsatisfiable axiom https://github.com/EnvironmentOntology/envo/runs/7767526832?check_suite_focus=true#step:4:26 * deleting envo-edit-module-merged.owl * fixing erroneous EAL patterns, manual reconfig of generated classes, IDs commented out in EAL txt module file * attempting fix of https://github.com/EnvironmentOntology/envo/runs/7771430536?check_suite_focus=true#step:4:26 * regenerating all modules Co-authored-by: Krishna Udaiwal <krishna.u@hotmail.com> Co-authored-by: pier.buttigieg <pier.buttigieg@gitlab.hzdr.de>
|
@celineaubert @marieALaporte I think this is addressed but not resolved by #1330 Note equivalence:
It seems that the PATO class wasn't imported in your PRs (you should rebuild the pato_import.owl file after adding the classes you need to pato_terms.txt) so ENVO doesn't know what that IRI is. Also, the air temperature class is obsolete. Also, not that characteristic of can't be directed towards a quality, although I get what you're trying to say. Not sure if we can express that with RO / OWL @cmungall. Let's open another PR on this issue to solve these issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
air temperature amplitude
airamplitude; http://purl.obolibrary.org/obo/PATO_0000080An amplitude quality inhering in air. It represents the difference between the highest air temperature and the lowest air temperature over a given periodeThe text was updated successfully, but these errors were encountered: