#420 added class 'soil drainage'

[KrishnaTO]

closes #420

[cmungall]

Hi @KrishnaTO

The logical definition you have chosen here is:

• flux and characteristic-of some liquid water

• It doesn't mention soil at all

• is the concept of flux really the same as drainage - they seem related to me but far from equivalent

Some general guidelines that apply across all ontologies:

• logical definitions should follow an established pattern and in general should be used for trivially compositional terms
• if you aren't completely sure of the logical definition, just use subClassOf instead
• logical definitions should match textual, see S11: https://douroucouli.wordpress.com/2019/07/08/ontotip-write-simple-concise-clear-operational-textual-definitions/
• provide more contextual summary in PRs

Additionally, some specific ENVO guidelines that may help with evaluation of your PRs in future

• we are not using obo format as the edit format this makes PRs harder to read. Until we get a diff bot set up, it can help if you provide a description of your PR. In this case "I need soil drainage for project X. I think this should be a characteristic of soil/water, so I made a logical definition 'characteristic of some water', this will be reasoned to be under Y in the release"

[marieALaporte]

Thanks @cmungall. We moved 'soil drainage' under 'hydrological process', and defined it as 'A hydrological process during which water moves across, through, and out of the soil as a result of the force of gravity.'
We added a subClassOf axiom 'occurs in some soil'
We need this term for the EiA initiative, where people record the soil drainage rate. We will create a PR for the rate term once this PR is accepted

[pbuttigieg]

I still see this under "flux" rather than process.

[marieALaporte]

@pbuttigieg soil drainage is under 'flux'

[marieALaporte]

I misunderstood your comment. Will make the change

[smrgeoinfo]

soil drainage process: a process by which water (or other liquid) is transported through a soil body. NOTE: typically gravity driven, and requires pressure gradients through connected soil porosity (e.g. permeability)
soil drainage flux: the volume of fluid transported through a soil volume per unit of time.