Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#427 added class 'runoff curve number' #1278

Closed
wants to merge 6 commits into from
Closed

#427 added class 'runoff curve number' #1278

wants to merge 6 commits into from

Conversation

KrishnaTO
Copy link
Contributor

@KrishnaTO KrishnaTO commented Dec 27, 2021 •
edited
Loading

@KrishnaTO
[EnvironmentOntology#361] Added class 'runoff'
a483691
@KrishnaTO
Added xref for definition
362f616
@KrishnaTO
EnvironmentOntology#420 added class 'soil drainage'
2fb52f4
@KrishnaTO
EnvironmentOntology#423 added classes per 'soil natural drainage class'
879a966 
Added classes:
- drainage [soil natural drainage class]
- excessively drained soil
- somewhat excessively drained soil
- well drained soil
- moderately well drained soil
- somewhat poorly drained soil
- poorly drained soil
- very poorly drained soil
@KrishnaTO
Merge branch 'issue-361' into issue-427
73d27c4
@KrishnaTO
EnvironmentOntology#427 added class 'runoff curve number'
41fe1b5 
Modded class DL for 'runoff' (confirm merge of Issue EnvironmentOntology#1244 )
cmungall
cmungall requested changes Jan 18, 2022
View reviewed changes
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of this PR suggests that you are adding one term, but I see many terms added in the PR

(It's possible you were doing something like branching off a branch here...)

Can you either change the content of the PR so it only added runoff curve number OR change the description of the PR

@KrishnaTO
Copy link
Contributor Author

The description of this PR suggests that you are adding one term, but I see many terms added in the PR

(It's possible you were doing something like branching off a branch here...)

Can you either change the content of the PR so it only added runoff curve number OR change the description of the PR

Yes, there are some branches being imported to create links and keep the reasoner happy.
Updated PR description to be more informative; let me know preference between:

  1. Combine PRs where branching is occurring (may have multiple issues per PR), or
  2. Keep to issue terms only (while references to other classes in PRs remain)?
  3. Leave as is, and just reference the dependent PRs in descriptions?

@celineaubert
Copy link

@marieALaporte you may close it, but have a look at the different PRs branched to this one to be sure closing does not affect them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall Awaiting requested review from cmungall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New class: runoff curve number
4 participants
@KrishnaTO @celineaubert @cmungall @marieALaporte