added freshwater stream and biome #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
won't build becasue blank node owl:someValuesFrom obsolete alga
aclum
previously approved these changes
Jan 11, 2024
This was referenced Jan 11, 2024
pbuttigieg
reviewed
Jan 16, 2024
pbuttigieg
reviewed
Jan 17, 2024
cmungall
previously requested changes
Jan 18, 2024
Thanks. I saw the thread in EnvO editors slack too. I'll try to reorient myself now and possibly open a new PR. |
|
@pbuttigieg @cmungall I think the PR is OK now. No more blending of axioms between stream water, freshwater stream, and freshwater stream biome. |
turbomam
dismissed
cmungall’s stale review
rewrote the PR. will request new review.
cmungall
reviewed
Jan 18, 2024
cmungall
requested changes
Jan 18, 2024
leaving has part fresheater stream in for now
for DOSDP compliance
created 'freshwater stream ecosystem' and followed biome.yaml pattern |
pbuttigieg
reviewed
Jan 18, 2024
cmungall
reviewed
Jan 19, 2024
cmungall
previously approved these changes
Jan 19, 2024
cmungall
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can't build release because