Skip to content

Commit

Permalink
Make sure the template project name is helloworld_appmodules (faceb…
Browse files Browse the repository at this point in the history
…ook#34417)

Summary:
Make sure the new app template uses the correct project CMake project name: `helloworld_appmodules`, otherwise the app will fail to load the dynamic library.

This was a copy-n-paste error from RNTester.

## Changelog

[Internal] - Make sure the template project name is `helloworld_appmodules`

Pull Request resolved: facebook#34417

Test Plan: Will test an app created with the New App template

Reviewed By: cipolleschi

Differential Revision: D38698682

Pulled By: cortinico

fbshipit-source-id: b09331a52989b3b131ea8ba627057febcb535ef8
  • Loading branch information
cortinico authored and roryabraham committed Aug 17, 2022
1 parent bc6e07c commit 066c66d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion template/android/app/src/main/jni/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 3.13)

# Define the library name here.
project(rntester_appmodules)
project(helloworld_appmodules)

# This file includes all the necessary to let you build your application with the New Architecture.
include(${REACT_ANDROID_DIR}/cmake-utils/ReactNative-application.cmake)

0 comments on commit 066c66d

Please sign in to comment.