Make sure the template project name is helloworld_appmodules
#34417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cortinico in dba6d56. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…ook#34417) Summary: Make sure the new app template uses the correct project CMake project name: `helloworld_appmodules`, otherwise the app will fail to load the dynamic library. This was a copy-n-paste error from RNTester. ## Changelog [Internal] - Make sure the template project name is `helloworld_appmodules` Pull Request resolved: facebook#34417 Test Plan: Will test an app created with the New App template Reviewed By: cipolleschi Differential Revision: D38698682 Pulled By: cortinico fbshipit-source-id: b09331a52989b3b131ea8ba627057febcb535ef8
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…ook#34417) Summary: Make sure the new app template uses the correct project CMake project name: `helloworld_appmodules`, otherwise the app will fail to load the dynamic library. This was a copy-n-paste error from RNTester. ## Changelog [Internal] - Make sure the template project name is `helloworld_appmodules` Pull Request resolved: facebook#34417 Test Plan: Will test an app created with the New App template Reviewed By: cipolleschi Differential Revision: D38698682 Pulled By: cortinico fbshipit-source-id: b09331a52989b3b131ea8ba627057febcb535ef8
kelset
pushed a commit
that referenced
this pull request
Aug 22, 2022
Summary: Make sure the new app template uses the correct project CMake project name: `helloworld_appmodules`, otherwise the app will fail to load the dynamic library. This was a copy-n-paste error from RNTester. ## Changelog [Internal] - Make sure the template project name is `helloworld_appmodules` Pull Request resolved: #34417 Test Plan: Will test an app created with the New App template Reviewed By: cipolleschi Differential Revision: D38698682 Pulled By: cortinico fbshipit-source-id: b09331a52989b3b131ea8ba627057febcb535ef8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure the new app template uses the correct project CMake project name:
helloworld_appmodules, otherwise the app will fail to load the dynamic library.This was a copy-n-paste error from RNTester.
Changelog
[Internal] - Make sure the template project name is
helloworld_appmodulesTest Plan
Will test an app created with the New App template