Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM demos wrong because Gmsh-created meshes are by default not ghosted #2556

Closed
garth-wells opened this issue Feb 26, 2023 · 2 comments · Fixed by #3433
Closed

EM demos wrong because Gmsh-created meshes are by default not ghosted #2556

garth-wells opened this issue Feb 26, 2023 · 2 comments · Fixed by #3433
Labels
bug Something isn't working demo New demo or demo enhancements/improvements
Milestone

Comments

@garth-wells
Copy link
Member

The EM demos (demo_axis.py, demo_pml.py, maybe more) compute wrong diagnostic quantities because some quantities involve interior facet integrals. Proper computation of interior facet integrals requires meshes to be ghosted by facet. But, gmshio.model_to_mesh by default does not use any ghosting.

We should really be able to tell whether or not the mesh has the required ghosting.

@garth-wells garth-wells added bug Something isn't working demo New demo or demo enhancements/improvements labels Feb 26, 2023
@garth-wells
Copy link
Member Author

@jorgensd thoughts?

@jorgensd
Copy link
Sponsor Member

jorgensd commented Mar 2, 2023

@jorgensd thoughts?

I guess we should be able to add a check when generating the form that we have the appropriate ghosting (at least for dS integrals).

At least a quick fix for the demos is to set the Ghost mode in the partitioner input to read_from_msh and model_to_mesh https://github.com/FEniCS/dolfinx/blob/main/python/dolfinx/io/gmshio.py#L170 for the two demos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working demo New demo or demo enhancements/improvements
Projects
None yet
3 participants