-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for interprocess facets when assembling interior facet integrals #3439
Conversation
…r interior facets.
Looks like it also needs updating docs |
Not a change is this PR, but what are "interprocess_facets"? The |
I've improved the docstring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
A long-standing issue in DOLFINx is that we do not warn the user that using
GhostMode.none
with interior facet integrals can result in undefined behavior.This includes:
#2556
and an attempt of addressing this was done in: #2574, but was rejected due to its non-trivial computations.
We do have
interprocess_facets
, which is a bi-product ofcreate_entities
which we can use to check that we have sufficient information when packing integration entities:dolfinx/cpp/dolfinx/mesh/Topology.h
Line 196 in d5f56d6
interprocess_facets
are facets owned by the current process that is shared with other processes.