Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for interprocess facets when assembling interior facet integrals #3439

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

jorgensd
Copy link
Sponsor Member

A long-standing issue in DOLFINx is that we do not warn the user that using GhostMode.none with interior facet integrals can result in undefined behavior.
This includes:
#2556
and an attempt of addressing this was done in: #2574, but was rejected due to its non-trivial computations.

We do have interprocess_facets, which is a bi-product of create_entities which we can use to check that we have sufficient information when packing integration entities:

const std::vector<std::int32_t>& interprocess_facets() const;

interprocess_facets are facets owned by the current process that is shared with other processes.

@jorgensd jorgensd added the enhancement New feature or request label Sep 26, 2024
@chrisrichardson
Copy link
Contributor

/// @returns Local indices and index map

Looks like it also needs updating docs

@garth-wells
Copy link
Member

garth-wells commented Sep 26, 2024

Not a change is this PR, but what are "interprocess_facets"? The mesh::Topology::interprocess_facets docstring is unclear.

@garth-wells
Copy link
Member

Not a change is this PR, but what are "interprocess_facets"? The mesh::Topology::interprocess_facets docstring is unclear.

I've improved the docstring.

@garth-wells garth-wells added this to the 0.9.0 milestone Sep 26, 2024
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@garth-wells garth-wells added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 493f776 Sep 26, 2024
27 checks passed
@garth-wells garth-wells deleted the dokken/ghost_mode_check branch September 26, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants