Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply_rhs! doesn't work with affine constraints #419

Closed
fredrikekre opened this issue Feb 15, 2022 · 0 comments · Fixed by #431
Closed

apply_rhs! doesn't work with affine constraints #419

fredrikekre opened this issue Feb 15, 2022 · 0 comments · Fixed by #431

Comments

@fredrikekre
Copy link
Member

I believe that

Ferrite.jl/src/Dofs/ConstraintHandler.jl

Lines 672 to 678 in 9bfc3ad

if condense_f
ac = acs[dcol]
for (d,v) in ac.entries
f[d] += f[col] * v
end
f[ac.constrained_dof] = 0.0
end
needs to be done inside apply_rhs!.
fredrikekre added a commit that referenced this issue Feb 26, 2022
@fredrikekre
AffineConstraints: Fix usage with get_rhs_data.
a3b7a71 
This applies affine constraints also in apply_rhs! for solving a system
with multiple right hand sides. Also adds tests, and removes the
workarounds for this bug in computational homogenization example.

Fixes #419.
@fredrikekre fredrikekre mentioned this issue Feb 26, 2022
Merged
fredrikekre added a commit that referenced this issue Feb 28, 2022
@fredrikekre
AffineConstraints: Fix usage with get_rhs_data. (#431)
4e35b2d 
This applies affine constraints also in apply_rhs! for solving a system
with multiple right hand sides. Also adds tests, and removes the
workarounds for this bug in computational homogenization example.

Fixes #419.
koehlerson pushed a commit that referenced this issue Apr 22, 2022
@fredrikekre @koehlerson
AffineConstraints: Fix usage with get_rhs_data. (#431)
75dbbe9 
This applies affine constraints also in apply_rhs! for solving a system
with multiple right hand sides. Also adds tests, and removes the
workarounds for this bug in computational homogenization example.

Fixes #419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AffineConstraints: Fix usage with get_rhs_data. Ferrite-FEM/Ferrite.jl
2 participants
@lijas @fredrikekre