AffineConstraints: Fix usage with get_rhs_data. #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies affine constraints also in apply_rhs! for solving a system with multiple right hand sides. Also adds tests, and removes the workarounds for this bug in computational homogenization example. Fixes #419.
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 91.29% 91.31% +0.02%
==========================================
Files 22 22
Lines 3250 3260 +10
==========================================
+ Hits 2967 2977 +10
Misses 283 283
Continue to review full report at Codecov.
|
lijas
reviewed
Feb 28, 2022
koehlerson
pushed a commit
that referenced
this pull request
Apr 22, 2022
This applies affine constraints also in apply_rhs! for solving a system with multiple right hand sides. Also adds tests, and removes the workarounds for this bug in computational homogenization example. Fixes #419.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies affine constraints also in apply_rhs! for solving a system
with multiple right hand sides. Also adds tests, and removes the
workarounds for this bug in computational homogenization example.
Fixes #419.