Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework code for add!(::ConstraintHandler, ::Dirichlet) #672

Merged
merged 1 commit into from
Apr 4, 2023

Commits on Apr 4, 2023

  1. Rework code for add!(::ConstraintHandler, ::Dirichlet)

    This patch cleans up the code for adding `Dirichlet` constraints to the
    `ConstraintHandler` a bit after the DofHandler merge. In particular, it
    deprecates the method
    ```
    add!(::ConstraintHandler, ::FieldHandler, ::Dirichlet)
    ```
    in favor of just
    ```
    add!(::ConstraintHandler, ::Dirichlet)
    ```
    which was added in #427. There is no need to be able to specify the
    constrained set by both the set passed to `Dirichlet` and by the set
    given to the `FieldHandler`. Looking at the tests modified in this
    patch, it seems this was never the intention anyway. This patch also
    removes the copy of the set in the `Dirichlet` constructor in favor of
    explicit partitioning of the set over the `FieldHandler`s.
    fredrikekre committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    7ccf8b8 View commit details
    Browse the repository at this point in the history