Rework code for add!(::ConstraintHandler, ::Dirichlet)
#672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #672 +/- ##
==========================================
- Coverage 93.47% 93.13% -0.35%
==========================================
Files 29 29
Lines 4273 4265 -8
==========================================
- Hits 3994 3972 -22
- Misses 279 293 +14
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
KnutAM
approved these changes
Apr 4, 2023
This patch cleans up the code for adding `Dirichlet` constraints to the `ConstraintHandler` a bit after the DofHandler merge. In particular, it deprecates the method ``` add!(::ConstraintHandler, ::FieldHandler, ::Dirichlet) ``` in favor of just ``` add!(::ConstraintHandler, ::Dirichlet) ``` which was added in #427. There is no need to be able to specify the constrained set by both the set passed to `Dirichlet` and by the set given to the `FieldHandler`. Looking at the tests modified in this patch, it seems this was never the intention anyway. This patch also removes the copy of the set in the `Dirichlet` constructor in favor of explicit partitioning of the set over the `FieldHandler`s.
fredrikekre
force-pushed
the
fe/fieldhandler-dbc
branch
from
ef0669b
to
7ccf8b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cleans up the code for adding
Dirichletconstraints to theConstraintHandlera bit after the DofHandler merge. In particular, it deprecates the methodin favor of just
which was added in #427. There is no need to be able to specify the constrained set by both the set passed to
Dirichletand by the set given to theFieldHandler. Looking at the tests modified in this patch, it seems this was never the intention anyway. This patch also removes the copy of the set in theDirichletconstructor in favor of explicit partitioning of the set over theFieldHandlers.