This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
Upgrade Node to v14 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - `package.json` field `engines.node` - updated, previously: `>=8.11.0` - `.nvmrc` - created - `.circleci/config.yml` Docker image for `container_config_node` - Docker updated, previously: `circleci/node:8-browsers`
andygout
force-pushed
the
upgrade-node-to-v14
branch
from
526fdca
to
52c203a
Compare
|
Checks performed:
No unit tests. 🤦 Ultimately this is not an app running in production rather than a series of scripts. If one of the scripts fails because of an incompatibility issue then it will simply mean that the script is not run, rather than a process in product failing. @nickramsbottom mentioned this issue - Array.sort arguments order changed in Node.js 11 - so I have specifically checked that this repo's use of |
antonsamper
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please run appropriate tests and checks to ensure that the app is compatible with this Node version. https://node.green is a useful reference.
This PR was created using a nori script 🍙
Nori is a command-line application for managing changes across multiple (usually Github) repositories.