Skip to content
This repository has been archived by the owner on Feb 19, 2024. It is now read-only.

Upgrade Node to v14 #77

Merged
merged 2 commits into from
Sep 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@

references:

container_config_node8: &container_config_node8
container_config_node14: &container_config_node14
working_directory: ~/project/build
docker:
- image: circleci/node:8-browsers
- image: circleci/node:14-browsers

workspace_root: &workspace_root
~/project
Expand Down Expand Up @@ -55,7 +55,7 @@ version: 2
jobs:

build:
<<: *container_config_node8
<<: *container_config_node14
steps:
- checkout
- run:
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
- build

test:
<<: *container_config_node8
<<: *container_config_node14
steps:
- *attach_workspace
- run:
Expand All @@ -101,7 +101,7 @@ jobs:
destination: test-results

publish:
<<: *container_config_node8
<<: *container_config_node14
steps:
- *attach_workspace
- run:
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
14.11
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ A useful CLI for working with Next's Elasticsearch clusters. Includes tools to s

## Prerequisites

- Node 8.11+
- Node version defined by `engines.node` in `package.json`. Run command `nvm use` to switch your local Node version to the one specified in `.nvmrc`.
- [Vault CLI](https://github.com/Financial-Times/vault/wiki/Getting-Started#login-with-the-cli) (optional, see notes below)

## Installation and setup
Expand Down Expand Up @@ -184,4 +184,4 @@ Rotating AWS keys means that eventually the `access_key` stored at `~/.n-es-tool
<TASK> failed: Authorization Exception :: {"path":"/content/item/_search","query":{"sort":"_doc","scroll":"1m","size":5000,"_source":"false"},"statusCode":403,"response":"{\"message\":\"The security token included in the request is invalid.\"}"}
```

Reinstalling `n-es-tools` will pull in the current `access_key` and should address this issue.
Reinstalling `n-es-tools` will pull in the current `access_key` and should address this issue.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
"standard": "^12.0.1"
},
"engines": {
"node": ">=8.11.0"
"node": "14.x"
}
}