Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client.disconnect doesn't always return a promise #235

Closed
tschellenbach opened this issue Jan 16, 2020 · 4 comments · Fixed by #254
Closed

client.disconnect doesn't always return a promise #235

tschellenbach opened this issue Jan 16, 2020 · 4 comments · Fixed by #254
Assignees
@jaapbakker88

Comments

@tschellenbach
Copy link
Member

image

client.disconnect doesn't return a promise if wsConnection is not defined...
@tschellenbach
Copy link
Member Author

2 more issues...

image

@tschellenbach
Copy link
Member Author

wsConnection.disconnect also doesn't seem entirely correct. I think the onClose event isn't fired if the socket is already closed... That might explain why Kane gets the above error

image

@kanekv
Copy link

kanekv commented Jan 24, 2020

Also, awaiting on client.disconnect is timing out.

@ferhatelmas ferhatelmas changed the title client.disconnect doens't always return a promise client.disconnect doesn't always return a promise Jan 24, 2020
@kanekv
Copy link

kanekv commented Feb 7, 2020

Some additional info: this happens in node.js every time.

@vishalnarkhede vishalnarkhede mentioned this issue Feb 8, 2020
Merged
3 tasks
kevinnath1007 pushed a commit to kevinnath1007/stream-chat-js that referenced this issue Aug 31, 2022
@agit26milan
Merge pull request GetStream#235 from BetterSocial/ping-1066-2
2badbd9 
Ping 1066 2 -  fix padding android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaapbakker88 jaapbakker88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing disconnect method GetStream/stream-chat-js
3 participants
@tschellenbach @kanekv @jaapbakker88