Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing disconnect method #254

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Fixing disconnect method #254

merged 2 commits into from
Feb 10, 2020

Conversation

vishalnarkhede
Copy link
Contributor

Submit a pull request

Fixes #235

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@vishalnarkhede
Copy link
Contributor Author

Approved by Thierry ... so gonna merge it!!

@vishalnarkhede vishalnarkhede merged commit 600da6c into master Feb 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the vishal/disconnect-fix branch February 10, 2020 16:41
mksglu pushed a commit to mksglu/stream-chat-js that referenced this pull request Jun 13, 2020
…-types

Add missing activity update type declarations
kevinnath1007 pushed a commit to kevinnath1007/stream-chat-js that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client.disconnect doesn't always return a promise
1 participant