Support fstab mount with hyphens #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1993 +/- ##
==========================================
+ Coverage 73.56% 73.62% +0.06%
==========================================
Files 97 97
Lines 10382 10382
==========================================
+ Hits 7637 7644 +7
+ Misses 2406 2400 -6
+ Partials 339 338 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested changes
Jun 11, 2024
ashmeenkaur
force-pushed
the
support_fstab_mount
branch
from
01bd505
to
496e739
Compare
kislaykishore
requested changes
Jun 12, 2024
ashmeenkaur
force-pushed
the
support_fstab_mount
branch
from
15a5236
to
c4782cf
Compare
kislaykishore
approved these changes
Jun 13, 2024
ashmeenkaur
requested review from
sethiay
and removed request for
vadlakondaswetha
sethiay
approved these changes
Jun 18, 2024
vadlakondaswetha
pushed a commit
that referenced
this pull request
Jul 31, 2024
Support fstab mount with hyphens (#1993) * add normalise function for fstab flags * allow passing gcsfuse hyphen flags in persistent mount * add missing flags * revert normalisation changes as it is not required * fix typo * add unit test * review comments * review comments * review comments * Prefix grpc_conn_pool_size with "experimental_" --------- Co-authored-by: Kislay Kishore <kislayk@google.com>
Closed
vadlakondaswetha
added a commit
that referenced
this pull request
Jul 31, 2024
This reverts commit 5eaf517.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GCSFuse persistent mounting does not allow inherent GCSFuse flags with hyphens '-'. This PR adds support for hyphens '-' in GCSFuse persistent mount with the backward compatibility of supporting underscores "_".
This PR also adds missing flags to the persistent mounting binary.
Link to the issue in case of a bug fix.
NA
Testing details
mount -tcommand./etc/fstabfile and then runningmount -a.mount_gcsfusebinary and using it for mounting.